chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java - Issue 1163173002: Pull methods upwards from ChromeTabCreator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java

index 3bc7fb2dde6a25c8948115983b99f42d7c973e90..5da1c414b1dd3a8d54e2ad5b65802a70442171ff 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java

@@ -9,7 +9,7 @@ import android.view.KeyEvent;

import com.google.android.apps.chrome.R;

import org.chromium.base.annotations.SuppressFBWarnings;

-import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;

+import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;

import org.chromium.chrome.browser.tabmodel.TabModel;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModelUtils;

@@ -138,7 +138,7 @@ public class KeyboardShortcuts {

if (currentTab != null && isCurrentTabVisible) {

currentTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOKMARK));

} else {

- ChromeTabCreator tabCreator = activity.getCurrentTabCreator();

+ TabCreator tabCreator = activity.getCurrentTabCreator();

if (tabCreator != null) {

tabCreator.launchUrl(url, TabLaunchType.FROM_KEYBOARD);

}