Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3795)

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
index ce3203ab4c66da4a8660154c6b3e77f6002aabc6..7ae18bf0158393b806df5babcb60579821eedaa2 100644
--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
@@ -244,6 +244,8 @@ public class DocumentTab extends ChromeTab {
@Override
public void webContentsCreated(WebContents sourceWebContents, long openerRenderFrameId,
String frameName, String targetUrl, WebContents newWebContents) {
+ // TODO(dfalcantara): Replace with TabObserver, combine with FullScreenActivityTab's
+ // WebContentsDelegateAndroidImpl.
super.webContentsCreated(sourceWebContents, openerRenderFrameId, frameName,
targetUrl, newWebContents);
long nativeNewWebContents =
@@ -255,6 +257,7 @@ public class DocumentTab extends ChromeTab {
@Override
public boolean addNewContents(WebContents sourceWebContents, WebContents webContents,
int disposition, Rect initialPosition, boolean userGesture) {
+ // TODO(dfalcantara): Set TabCreators on DocumentActivity, replace with super method.
if (isClosing()) return false;
long nativeWebContents =
ContentViewUtil.getNativeWebContentsFromWebContents(webContents);

Powered by Google App Engine
This is Rietveld 408576698