Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java
diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java
index 1241501ff5fba993e5c76c91c65a366cd3c8dcb4..79b102d9a1987c809288c4f3d21d5f28a126b7dc 100644
--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java
+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java
@@ -14,9 +14,9 @@ import com.google.android.apps.chrome.R;
import org.chromium.chrome.browser.Tab;
import org.chromium.chrome.browser.appmenu.AppMenuHandler;
import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;
-import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;
import org.chromium.chrome.browser.tabmodel.EmptyTabModelObserver;
import org.chromium.chrome.browser.tabmodel.EmptyTabModelSelectorObserver;
+import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;
import org.chromium.chrome.browser.tabmodel.TabModel;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModelObserver;
@@ -31,7 +31,7 @@ import java.util.List;
public class EmptyBackgroundViewWrapper {
private final Activity mActivity;
private final TabModelSelector mTabModelSelector;
- private final ChromeTabCreator mTabCreator;
+ private final TabCreator mTabCreator;
private final TabModelObserver mTabModelObserver;
private final TabModelSelectorObserver mTabModelSelectorObserver;
private final OverviewModeBehavior mOverviewModeBehavior;
@@ -43,15 +43,14 @@ public class EmptyBackgroundViewWrapper {
* Creates a {@link EmptyBackgroundViewWrapper} instance that will lazily inflate.
* @param selector A {@link TabModelSelector} that will be used to query system
* state.
- * @param tabCreator A {@link ChromeTabCreator} that will be used to open the New Tab
- * Page.
+ * @param tabCreator A {@link TabCreator} that will be used to open the New Tab Page.
* @param activity An {@link Activity} that represents a parent of the
* {@link android.view.ViewStub}.
* @param menuHandler A {@link AppMenuHandler} to handle menu touch events.
* @param overviewModeBehavior A {@link OverviewModeBehavior} instance to detect when the app
* is in overview mode.
*/
- public EmptyBackgroundViewWrapper(TabModelSelector selector, ChromeTabCreator tabCreator,
+ public EmptyBackgroundViewWrapper(TabModelSelector selector, TabCreator tabCreator,
Activity activity, AppMenuHandler menuHandler,
OverviewModeBehavior overviewModeBehavior) {
mActivity = activity;

Powered by Google App Engine
This is Rietveld 408576698