chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java - Issue 1163173002: Pull methods upwards from ChromeTabCreator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java

index b2ed0f43785cb5e6ac5ded9bee4b3043ea70f31e..bdabb0b414de9895b41d5dc055b743d19f6b1a7e 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewTablet.java

@@ -19,7 +19,7 @@ import com.google.android.apps.chrome.R;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.browser.appmenu.AppMenuButtonHelper;

import org.chromium.chrome.browser.appmenu.AppMenuHandler;

-import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;

+import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

import org.chromium.chrome.browser.widget.incognitotoggle.IncognitoToggleButtonTablet;

import org.chromium.ui.UiUtils;

@@ -32,7 +32,7 @@ public class EmptyBackgroundViewTablet extends FrameLayout {

private static final int ANIMATE_DURATION_MS = 200;

private TabModelSelector mTabModelSelector;

- private ChromeTabCreator mTabCreator;

+ private TabCreator mTabCreator;

private Animator mCurrentTransitionAnimation;

@@ -80,10 +80,10 @@ public class EmptyBackgroundViewTablet extends FrameLayout {

}

/**

- * Sets the {@link ChromeTabCreator} that will be used to open the New Tab Page.

- * @param tabCreator A {@link ChromeTabCreator} to open the New Tab Page.

+ * Sets the {@link TabCreator} that will be used to open the New Tab Page.

+ * @param tabCreator A {@link TabCreator} to open the New Tab Page.

- public void setTabCreator(ChromeTabCreator tabCreator) {

+ public void setTabCreator(TabCreator tabCreator) {

mTabCreator = tabCreator;

}