chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java - Issue 1163173002: Pull methods upwards from ChromeTabCreator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/KeyboardShortcuts.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

index 342e5d1841bad666d2da33a66edf87daa051558f..bfe8ea5111e1b2bb934181d7d55517cc796f1b58 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

@@ -55,7 +55,7 @@ import org.chromium.chrome.browser.printing.TabPrinter;

import org.chromium.chrome.browser.snackbar.LoFiBarPopupController;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;

-import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;

+import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

import org.chromium.chrome.browser.tabmodel.TabModelSelectorTabObserver;

@@ -559,7 +559,7 @@ public abstract class CompositorChromeActivity extends ChromeActivity

Tab currentTab = getActivityTab();

if (currentTab == null) return false;

- ChromeTabCreator tabCreator = getTabCreator(currentTab.isIncognito());

+ TabCreator tabCreator = getTabCreator(currentTab.isIncognito());

if (tabCreator == null) return false;

tabCreator.createTabWithWebContents(searchContentViewCore.getWebContents(),