chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java - Issue 1163173002: Pull methods upwards from ChromeTabCreator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java

index 9b3455cd45d75f382d9c386a1612d44eb41dcc08..e47771e3cdd18b3e12a1603693b1aeaca0f02925 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java

@@ -8,7 +8,10 @@ import org.chromium.components.web_contents_delegate_android.WebContentsDelegate

import org.chromium.content_public.browser.WebContents;

/**

- * Stubs out calls to the WebContentsDelegateAndroid.

+ * Stubs out calls to the WebContentsDelegateAndroid. Attaching a WebContentsDelegateAndroid to a

+ * newly created WebContents signals to Chrome that it was created properly, which is needed in

+ * situations where Chrome on Android needs to create the Activity for the WebContents

+ * asynchronously.

public class DocumentWebContentsDelegate extends WebContentsDelegateAndroid {

/**