chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java - Issue 1163173002: Pull methods upwards from ChromeTabCreator.

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

Issue 1163173002: Pull methods upwards from ChromeTabCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/widget/emptybackground/EmptyBackgroundViewWrapper.java ('k') | chrome/android/javatests_shell/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

index 9ceb1636102df1941c251e2d536f109b3a8c305c..1d529a978228c102c110e604aa01fde198283260 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

@@ -12,7 +12,7 @@ import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.browser.compositor.layouts.Layout;

-import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;

+import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

import org.chromium.chrome.browser.tabmodel.TabModelUtils;

@@ -117,7 +117,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

@Override

public void run() {

// Foreground tab.

- ChromeTabCreator tabCreator = getActivity().getCurrentTabCreator();

+ TabCreator tabCreator = getActivity().getCurrentTabCreator();

tabs[0] = tabCreator.createNewTab(

new LoadUrlParams(TestHttpServerClient.getUrl(FILE_PATH)),

TabLaunchType.FROM_KEYBOARD, null);

@@ -189,7 +189,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

@Override

public void run() {

// Foreground tab.

- ChromeTabCreator tabCreator = getActivity().getCurrentTabCreator();

+ TabCreator tabCreator = getActivity().getCurrentTabCreator();

tabs[0] = tabCreator.createNewTab(

new LoadUrlParams(TestHttpServerClient.getUrl(FILE_PATH)),

TabLaunchType.FROM_KEYBOARD, null);

@@ -301,7 +301,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

new Callable<Tab>() {

@Override

public Tab call() throws Exception {

- ChromeTabCreator tabCreator = getActivity().getCurrentTabCreator();

+ TabCreator tabCreator = getActivity().getCurrentTabCreator();

return tabCreator.createNewTab(

new LoadUrlParams(TestHttpServerClient.getUrl(FILE_PATH)),

TabLaunchType.FROM_KEYBOARD, null);

@@ -373,7 +373,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

new Callable<Tab>() {

@Override

public Tab call() {

- ChromeTabCreator tabCreator = getActivity().getCurrentTabCreator();

+ TabCreator tabCreator = getActivity().getCurrentTabCreator();

return tabCreator.createNewTab(

new LoadUrlParams(TestHttpServerClient.getUrl(FILE_PATH)),

TabLaunchType.FROM_KEYBOARD, null);

@@ -406,7 +406,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

new Callable<Tab>() {

@Override

public Tab call() {

- ChromeTabCreator tabCreator = getActivity().getCurrentTabCreator();

+ TabCreator tabCreator = getActivity().getCurrentTabCreator();

Tab tab = tabCreator.createNewTab(

new LoadUrlParams(TestHttpServerClient.getUrl(FILE_PATH)),

TabLaunchType.FROM_LONGPRESS_BACKGROUND, null);