Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/

Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/

BUG=472381
Committed: https://crrev.com/91cb231942efd931eb43b463f890d5f2f4671f95
Cr-Commit-Position: refs/heads/master@{#331545}

[payal.pandey, 2015-05-25 10:30:05]

payal.pandey@samsung.com changed reviewers:
+ eroman@chromium.org

[payal.pandey, 2015-05-25 10:30:06]

Please have a look, Thanks

[eroman, 2015-05-25 17:50:47]

https://codereview.chromium.org/1158653002/diff/20001/net/http/http_network_s...
File net/http/http_network_session.h (right):

https://codereview.chromium.org/1158653002/diff/20001/net/http/http_network_s...
net/http/http_network_session.h:190: // Creates a Value summary of the state of
the SPDY sessions. The caller is
Remove the comment on ownership

https://codereview.chromium.org/1158653002/diff/20001/net/log/net_log_util.cc
File net/log/net_log_util.cc (right):

https://codereview.chromium.org/1158653002/diff/20001/net/log/net_log_util.cc...
net/log/net_log_util.cc:417:
http_network_session->SpdySessionPoolInfoToValue().Pass());
Same comment as on other changelist -- there is no need to call Pass() when the
result is already a temporary

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session.h...
net/spdy/spdy_session.h:400: // Value.  Caller takes possession of the returned
value.
Remove comment on ownership

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
File net/spdy/spdy_session_pool.cc (right):

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
net/spdy/spdy_session_pool.cc:261:
list->Append(it->second->GetInfoAsValue().Pass());
No Pass()

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
File net/spdy/spdy_session_pool.h (right):

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
net/spdy/spdy_session_pool.h:122: // Creates a Value summary of the state of the
spdy session pool. The caller
Remove ownership comment

[payal.pandey, 2015-05-26 06:07:35]

Updated as per review comments.
Please have a look again, thanks.

https://codereview.chromium.org/1158653002/diff/20001/net/http/http_network_s...
File net/http/http_network_session.h (right):

https://codereview.chromium.org/1158653002/diff/20001/net/http/http_network_s...
net/http/http_network_session.h:190: // Creates a Value summary of the state of
the SPDY sessions. The caller is
On 2015/05/25 17:50:46, eroman wrote:
> Remove the comment on ownership

Done.

https://codereview.chromium.org/1158653002/diff/20001/net/log/net_log_util.cc
File net/log/net_log_util.cc (right):

https://codereview.chromium.org/1158653002/diff/20001/net/log/net_log_util.cc...
net/log/net_log_util.cc:417:
http_network_session->SpdySessionPoolInfoToValue().Pass());
On 2015/05/25 17:50:46, eroman wrote:
> Same comment as on other changelist -- there is no need to call Pass() when
the
> result is already a temporary

Done.

https://codereview.chromium.org/1158653002/diff/20001/net/log/net_log_util.cc...
net/log/net_log_util.cc:417:
http_network_session->SpdySessionPoolInfoToValue().Pass());
On 2015/05/25 17:50:46, eroman wrote:
> Same comment as on other changelist -- there is no need to call Pass() when
the
> result is already a temporary

Acknowledged.

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session.h...
net/spdy/spdy_session.h:400: // Value.  Caller takes possession of the returned
value.
On 2015/05/25 17:50:46, eroman wrote:
> Remove comment on ownership

Done.

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
File net/spdy/spdy_session_pool.cc (right):

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
net/spdy/spdy_session_pool.cc:261:
list->Append(it->second->GetInfoAsValue().Pass());
On 2015/05/25 17:50:46, eroman wrote:
> No Pass()

Done.

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
File net/spdy/spdy_session_pool.h (right):

https://codereview.chromium.org/1158653002/diff/20001/net/spdy/spdy_session_p...
net/spdy/spdy_session_pool.h:122: // Creates a Value summary of the state of the
spdy session pool. The caller
On 2015/05/25 17:50:46, eroman wrote:
> Remove ownership comment

Done.

[eroman, 2015-05-26 18:12:39]

lgtm once you address the comment

https://codereview.chromium.org/1158653002/diff/40001/net/http/http_network_s...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/1158653002/diff/40001/net/http/http_network_s...
net/http/http_network_session.cc:259: return
spdy_session_pool_.SpdySessionPoolInfoToValue().Pass();
Remove Pass()

[payal.pandey, 2015-05-27 06:36:14]

Sorry, missed to update this change
>
https://codereview.chromium.org/1158653002/diff/40001/net/http/http_network_s...
> net/http/http_network_session.cc:259: return
> spdy_session_pool_.SpdySessionPoolInfoToValue().Pass();
> Remove Pass()

[payal.pandey, 2015-05-27 06:36:30]

The CQ bit was checked by payal.pandey@samsung.com

[payal.pandey, 2015-05-27 06:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1158653002/#ps60001
(title: "Incorporated review comments.")

[commit-bot: I haz the power, 2015-05-27 06:36:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158653002/60001

[commit-bot: I haz the power, 2015-05-27 07:42:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-27 07:42:51]

Patchset 4 (id:??) landed as
https://crrev.com/91cb231942efd931eb43b463f890d5f2f4671f95
Cr-Commit-Position: refs/heads/master@{#331545}