Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/

net/spdy/spdy_session_pool.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session_pool.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/values.h"
@@ skipping 230 matching lines @@
                              true /* idle_only */);
 }
 
 void SpdySessionPool::CloseAllSessions() {
   while (!available_sessions_.empty()) {
     CloseCurrentSessionsHelper(ERR_ABORTED, "Closing all sessions.",
                                false /* idle_only */);
   }
 }
 
-base::Value* SpdySessionPool::SpdySessionPoolInfoToValue() const {
-  base::ListValue* list = new base::ListValue();
+scoped_ptr<base::Value> SpdySessionPool::SpdySessionPoolInfoToValue() const {
+  scoped_ptr<base::ListValue> list(new base::ListValue());
 
   for (AvailableSessionMap::const_iterator it = available_sessions_.begin();
        it != available_sessions_.end(); ++it) {
     // Only add the session if the key in the map matches the main
     // host_port_proxy_pair (not an alias).
     const SpdySessionKey& key = it->first;
     const SpdySessionKey& session_key = it->second->spdy_session_key();
     if (key.Equals(session_key))
-      list->Append(it->second->GetInfoAsValue());
+      list->Append(it->second->GetInfoAsValue().Pass());

[eroman, 2015/05/25 17:50:46]

No Pass()

[payal.pandey, 2015/05/26 06:07:35]

Done.

   }
-  return list;
+  return list.Pass();
 }
 
 void SpdySessionPool::OnIPAddressChanged() {
   WeakSessionList current_sessions = GetCurrentSessions();
   for (WeakSessionList::const_iterator it = current_sessions.begin();
        it != current_sessions.end(); ++it) {
     if (!*it)
       continue;
 
 // For OSs that terminate TCP connections upon relevant network changes,
@@ skipping 96 matching lines @@
 
     if (idle_only && (*it)->is_active())
       continue;
 
     (*it)->CloseSessionOnError(error, description);
     DCHECK(!IsSessionAvailable(*it));
   }
 }
 
 }  // namespace net