Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: net/spdy/spdy_session.cc

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_session_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index cbb8630bd181a2e722599f70cdbc541306bfeb6d..69c55421e0ae7e421dabfa8cb813e0ed468490ad 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -1795,7 +1795,7 @@ void SpdySession::MakeUnavailable() {
}
}
-base::Value* SpdySession::GetInfoAsValue() const {
+scoped_ptr<base::Value> SpdySession::GetInfoAsValue() const {
scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetInteger("source_id", net_log_.source().id);
@@ -1839,7 +1839,7 @@ base::Value* SpdySession::GetInfoAsValue() const {
dict->SetInteger("recv_window_size", session_recv_window_size_);
dict->SetInteger("unacked_recv_window_bytes",
session_unacked_recv_window_bytes_);
- return dict.release();
+ return dict.Pass();
}
bool SpdySession::IsReused() const {
« no previous file with comments | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_session_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698