net/spdy/spdy_session.h - Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.h

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_session.h

diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h

index fdbf73dfc20e8ca40c63d4764dd08f1fcfd82f36..8c25ec963da76f4651b7d3fcb5fccf44ac775443 100644

--- a/net/spdy/spdy_session.h

+++ b/net/spdy/spdy_session.h

@@ -397,8 +397,8 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,

void MaybeFinishGoingAway();

// Retrieves information on the current state of the SPDY session as a

- // Value. Caller takes possession of the returned value.

- base::Value* GetInfoAsValue() const;

+ // Value.

+ scoped_ptr<base::Value> GetInfoAsValue() const;

// Indicates whether the session is being reused after having successfully

// used to send/receive data in the past or if the underlying socket was idle

« no previous file with comments | « net/http/http_network_session.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »