Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: net/spdy/spdy_session_pool.h

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_SPDY_SESSION_POOL_H_ 5 #ifndef NET_SPDY_SPDY_SESSION_POOL_H_
6 #define NET_SPDY_SPDY_SESSION_POOL_H_ 6 #define NET_SPDY_SPDY_SESSION_POOL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 112
113 // Close only the currently existing SpdySessions that are idle. 113 // Close only the currently existing SpdySessions that are idle.
114 // Let any new ones created while this method is running continue to 114 // Let any new ones created while this method is running continue to
115 // live. 115 // live.
116 void CloseCurrentIdleSessions(); 116 void CloseCurrentIdleSessions();
117 117
118 // Close all SpdySessions, including any new ones created in the process of 118 // Close all SpdySessions, including any new ones created in the process of
119 // closing the current ones. 119 // closing the current ones.
120 void CloseAllSessions(); 120 void CloseAllSessions();
121 121
122 // Creates a Value summary of the state of the spdy session pool. The caller 122 // Creates a Value summary of the state of the spdy session pool.
123 // responsible for deleting the returned value. 123 scoped_ptr<base::Value> SpdySessionPoolInfoToValue() const;
124 base::Value* SpdySessionPoolInfoToValue() const;
125 124
126 base::WeakPtr<HttpServerProperties> http_server_properties() { 125 base::WeakPtr<HttpServerProperties> http_server_properties() {
127 return http_server_properties_; 126 return http_server_properties_;
128 } 127 }
129 128
130 // NetworkChangeNotifier::IPAddressObserver methods: 129 // NetworkChangeNotifier::IPAddressObserver methods:
131 130
132 // We flush all idle sessions and release references to the active ones so 131 // We flush all idle sessions and release references to the active ones so
133 // they won't get re-used. The active ones will either complete successfully 132 // they won't get re-used. The active ones will either complete successfully
134 // or error out due to the IP address change. 133 // or error out due to the IP address change.
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 // This SPDY proxy is allowed to push resources from origins that are 219 // This SPDY proxy is allowed to push resources from origins that are
221 // different from those of their associated streams. 220 // different from those of their associated streams.
222 HostPortPair trusted_spdy_proxy_; 221 HostPortPair trusted_spdy_proxy_;
223 222
224 DISALLOW_COPY_AND_ASSIGN(SpdySessionPool); 223 DISALLOW_COPY_AND_ASSIGN(SpdySessionPool);
225 }; 224 };
226 225
227 } // namespace net 226 } // namespace net
228 227
229 #endif // NET_SPDY_SPDY_SESSION_POOL_H_ 228 #endif // NET_SPDY_SPDY_SESSION_POOL_H_
OLDNEW
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698