Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: net/http/http_network_session.h

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_NETWORK_SESSION_H_ 5 #ifndef NET_HTTP_HTTP_NETWORK_SESSION_H_
6 #define NET_HTTP_HTTP_NETWORK_SESSION_H_ 6 #define NET_HTTP_HTTP_NETWORK_SESSION_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 return http_stream_factory_for_websocket_.get(); 180 return http_stream_factory_for_websocket_.get();
181 } 181 }
182 NetLog* net_log() { 182 NetLog* net_log() {
183 return net_log_; 183 return net_log_;
184 } 184 }
185 185
186 // Creates a Value summary of the state of the socket pools. The caller is 186 // Creates a Value summary of the state of the socket pools. The caller is
187 // responsible for deleting the returned value. 187 // responsible for deleting the returned value.
188 base::Value* SocketPoolInfoToValue() const; 188 base::Value* SocketPoolInfoToValue() const;
189 189
190 // Creates a Value summary of the state of the SPDY sessions. The caller is 190 // Creates a Value summary of the state of the SPDY sessions.
191 // responsible for deleting the returned value. 191 scoped_ptr<base::Value> SpdySessionPoolInfoToValue() const;
192 base::Value* SpdySessionPoolInfoToValue() const;
193 192
194 // Creates a Value summary of the state of the QUIC sessions and 193 // Creates a Value summary of the state of the QUIC sessions and
195 // configuration. The caller is responsible for deleting the returned value. 194 // configuration. The caller is responsible for deleting the returned value.
196 base::Value* QuicInfoToValue() const; 195 base::Value* QuicInfoToValue() const;
197 196
198 void CloseAllConnections(); 197 void CloseAllConnections();
199 void CloseIdleConnections(); 198 void CloseIdleConnections();
200 199
201 // Returns the original Params used to construct this session. 200 // Returns the original Params used to construct this session.
202 const Params& params() const { return params_; } 201 const Params& params() const { return params_; }
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 239
241 NextProtoVector next_protos_; 240 NextProtoVector next_protos_;
242 bool enabled_protocols_[NUM_VALID_ALTERNATE_PROTOCOLS]; 241 bool enabled_protocols_[NUM_VALID_ALTERNATE_PROTOCOLS];
243 242
244 Params params_; 243 Params params_;
245 }; 244 };
246 245
247 } // namespace net 246 } // namespace net
248 247
249 #endif // NET_HTTP_HTTP_NETWORK_SESSION_H_ 248 #endif // NET_HTTP_HTTP_NETWORK_SESSION_H_
OLDNEW
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698