Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: net/http/http_network_session.h

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.h
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index 43c6e04481686ff17df92c164c7a76e229f3c485..184e20ec3df75f2155134bca95c21f78da738a99 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -187,9 +187,8 @@ class NET_EXPORT HttpNetworkSession
// responsible for deleting the returned value.
base::Value* SocketPoolInfoToValue() const;
- // Creates a Value summary of the state of the SPDY sessions. The caller is
- // responsible for deleting the returned value.
- base::Value* SpdySessionPoolInfoToValue() const;
+ // Creates a Value summary of the state of the SPDY sessions.
+ scoped_ptr<base::Value> SpdySessionPoolInfoToValue() const;
// Creates a Value summary of the state of the QUIC sessions and
// configuration. The caller is responsible for deleting the returned value.
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698