Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/

net/log/net_log_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/log/net_log_util.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 394 matching lines @@
 
   HttpNetworkSession* http_network_session =
       context->http_transaction_factory()->GetSession();
 
   if (info_sources & NET_INFO_SOCKET_POOL) {
     net_info_dict->Set(NetInfoSourceToString(NET_INFO_SOCKET_POOL),
                        http_network_session->SocketPoolInfoToValue());
   }
 
   if (info_sources & NET_INFO_SPDY_SESSIONS) {
-    net_info_dict->Set(NetInfoSourceToString(NET_INFO_SPDY_SESSIONS),
-                       http_network_session->SpdySessionPoolInfoToValue());
+    net_info_dict->Set(
+        NetInfoSourceToString(NET_INFO_SPDY_SESSIONS),
+        http_network_session->SpdySessionPoolInfoToValue().Pass());

[eroman, 2015/05/25 17:50:46]

Same comment as on other changelist -- there is no need to call Pass() when the
result is already a temporary

[payal.pandey, 2015/05/26 06:07:35]

Acknowledged.

[payal.pandey, 2015/05/26 06:07:35]

Done.

   }
 
   if (info_sources & NET_INFO_SPDY_STATUS) {
     base::DictionaryValue* status_dict = new base::DictionaryValue();
 
     status_dict->SetBoolean("spdy_enabled", HttpStreamFactory::spdy_enabled());
     status_dict->SetBoolean(
         "use_alternate_protocols",
         http_network_session->params().use_alternate_protocols);
 
@@ skipping 88 matching lines @@
     // fine, since GetRequestStateAsValue() ignores the capture mode.
     NetLog::EntryData entry_data(
         NetLog::TYPE_REQUEST_ALIVE, request->net_log().source(),
         NetLog::PHASE_BEGIN, request->creation_time(), &callback);
     NetLog::Entry entry(&entry_data, NetLogCaptureMode::Default());
     observer->OnAddEntry(entry);
   }
 }
 
 }  // namespace net