Re-land: gin: Use V8 Maybe APIs

Re-land: gin: Use V8 Maybe APIs

The previous CL was reverted because it broke layout tests.

Cause:
GetKeyModifiersFromV8() in test_runner/event_sender.cc passes
NULL as v8::Isolate*, which is cleary wrong. Pass
blink::mainThreadIsolate() as the other callsites do.

BUG=479439
Committed: https://crrev.com/dbd2ef9bb16d7fb63f44a992248b4dbed7f3f8e3
Cr-Commit-Position: refs/heads/master@{#332312}

[bashi, 2015-05-29 08:20:33]

bashi@chromium.org changed reviewers:
+ jochen@chromium.org

[bashi, 2015-05-29 08:20:34]

PTAL?

https://codereview.chromium.org/1152653004/diff/1/content/shell/renderer/test...
File content/shell/renderer/test_runner/event_sender.cc (right):

https://codereview.chromium.org/1152653004/diff/1/content/shell/renderer/test...
content/shell/renderer/test_runner/event_sender.cc:126: isolate, value,
&modifier_names);
This is the only diff from the original CL.

[jochen (gone - plz use gerrit), 2015-05-29 11:28:30]

lgtm with comment

https://codereview.chromium.org/1152653004/diff/1/content/shell/renderer/test...
File content/shell/renderer/test_runner/event_sender.cc (right):

https://codereview.chromium.org/1152653004/diff/1/content/shell/renderer/test...
content/shell/renderer/test_runner/event_sender.cc:126: isolate, value,
&modifier_names);
On 2015/05/29 at 08:20:34, bashi1 wrote:
> This is the only diff from the original CL.

can you add the Isolate* as argument to this method? All callsites have a
gin::Arguments instance from which you can get the isolate

[bashi, 2015-06-02 00:12:06]

https://codereview.chromium.org/1152653004/diff/1/content/shell/renderer/test...
File content/shell/renderer/test_runner/event_sender.cc (right):

https://codereview.chromium.org/1152653004/diff/1/content/shell/renderer/test...
content/shell/renderer/test_runner/event_sender.cc:126: isolate, value,
&modifier_names);
On 2015/05/29 11:28:29, jochen wrote:
> On 2015/05/29 at 08:20:34, bashi1 wrote:
> > This is the only diff from the original CL.
> 
> can you add the Isolate* as argument to this method? All callsites have a
> gin::Arguments instance from which you can get the isolate

Done.

[bashi, 2015-06-02 00:12:11]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-06-02 00:12:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1152653004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-06-02 00:18:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152653004/20001

[commit-bot: I haz the power, 2015-06-02 01:39:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-02 01:41:26]

Patchset 2 (id:??) landed as
https://crrev.com/dbd2ef9bb16d7fb63f44a992248b4dbed7f3f8e3
Cr-Commit-Position: refs/heads/master@{#332312}