Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: gin/wrappable.cc

Issue 1152653004: Re-land: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/try_catch.cc ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/wrappable.h" 5 #include "gin/wrappable.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "gin/object_template_builder.h" 8 #include "gin/object_template_builder.h"
9 #include "gin/per_isolate_data.h" 9 #include "gin/per_isolate_data.h"
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 } 42 }
43 43
44 PerIsolateData* data = PerIsolateData::From(isolate); 44 PerIsolateData* data = PerIsolateData::From(isolate);
45 v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info); 45 v8::Local<v8::ObjectTemplate> templ = data->GetObjectTemplate(info);
46 if (templ.IsEmpty()) { 46 if (templ.IsEmpty()) {
47 templ = GetObjectTemplateBuilder(isolate).Build(); 47 templ = GetObjectTemplateBuilder(isolate).Build();
48 CHECK(!templ.IsEmpty()); 48 CHECK(!templ.IsEmpty());
49 data->SetObjectTemplate(info, templ); 49 data->SetObjectTemplate(info, templ);
50 } 50 }
51 CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount()); 51 CHECK_EQ(kNumberOfInternalFields, templ->InternalFieldCount());
52 v8::Local<v8::Object> wrapper = templ->NewInstance(); 52 v8::Local<v8::Object> wrapper;
53 // |wrapper| may be empty in some extreme cases, e.g., when 53 // |wrapper| may be empty in some extreme cases, e.g., when
54 // Object.prototype.constructor is overwritten. 54 // Object.prototype.constructor is overwritten.
55 if (wrapper.IsEmpty()) { 55 if (!templ->NewInstance(isolate->GetCurrentContext()).ToLocal(&wrapper)) {
56 // The current wrappable object will be no longer managed by V8. Delete this 56 // The current wrappable object will be no longer managed by V8. Delete this
57 // now. 57 // now.
58 delete this; 58 delete this;
59 return wrapper; 59 return wrapper;
60 } 60 }
61 wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info); 61 wrapper->SetAlignedPointerInInternalField(kWrapperInfoIndex, info);
62 wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this); 62 wrapper->SetAlignedPointerInInternalField(kEncodedValueIndex, this);
63 wrapper_.Reset(isolate, wrapper); 63 wrapper_.Reset(isolate, wrapper);
64 wrapper_.SetWeak(this, FirstWeakCallback, v8::WeakCallbackType::kParameter); 64 wrapper_.SetWeak(this, FirstWeakCallback, v8::WeakCallbackType::kParameter);
65 return wrapper; 65 return wrapper;
(...skipping 18 matching lines...) Expand all
84 // instance of the C++ class associated with wrapper_info. 84 // instance of the C++ class associated with wrapper_info.
85 if (info != wrapper_info) 85 if (info != wrapper_info)
86 return NULL; 86 return NULL;
87 87
88 return obj->GetAlignedPointerFromInternalField(kEncodedValueIndex); 88 return obj->GetAlignedPointerFromInternalField(kEncodedValueIndex);
89 } 89 }
90 90
91 } // namespace internal 91 } // namespace internal
92 92
93 } // namespace gin 93 } // namespace gin
OLDNEW
« no previous file with comments | « gin/try_catch.cc ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698