Re-land: gin: Use V8 Maybe APIs

content/shell/renderer/test_runner/event_sender.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/event_sender.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
@@ skipping 103 matching lines @@
     modifiers |= GetKeyModifier(*it);
   }
   return modifiers;
 }
 
 int GetKeyModifiersFromV8(v8::Local<v8::Value> value) {
   std::vector<std::string> modifier_names;
   if (value->IsString()) {
     modifier_names.push_back(gin::V8ToString(value));
   } else if (value->IsArray()) {
+    v8::Isolate* isolate = blink::mainThreadIsolate();
     gin::Converter<std::vector<std::string> >::FromV8(
-        NULL, value, &modifier_names);
+        isolate, value, &modifier_names);

[bashi, 2015/05/29 08:20:34]

This is the only diff from the original CL.

[jochen (gone - plz use gerrit), 2015/05/29 11:28:29]

can you add the Isolate* as argument to this method? All callsites have a
gin::Arguments instance from which you can get the isolate

[bashi, 2015/06/02 00:12:05]

Done.

   }
   return GetKeyModifiers(modifier_names);
 }
 
 // Maximum distance (in space and time) for a mouse click to register as a
 // double or triple click.
 const double kMultipleClickTimeSec = 1;
 const int kMultipleClickRadiusPixels = 5;
 const char kSubMenuDepthIdentifier[] = "_";
 const char kSubMenuIdentifier[] = " >";
@@ skipping 2381 matching lines @@
 
 bool EventSender::HandleInputEventOnViewOrPopup(const WebInputEvent& event) {
   if (WebPagePopup* popup = view_->pagePopup()) {
     if (!WebInputEvent::isKeyboardEventType(event.type))
       return popup->handleInputEvent(event);
   }
   return view_->handleInputEvent(event);
 }
 
 }  // namespace content