Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: gin/wrappable_unittest.cc

Issue 1152653004: Re-land: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/wrappable.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/wrappable_unittest.cc
diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc
index 3d795716de4a907ed06478055589edf621e120c7..70cb22458840e4ff09a8af1ddda2b7f6a273f788 100644
--- a/gin/wrappable_unittest.cc
+++ b/gin/wrappable_unittest.cc
@@ -183,7 +183,7 @@ TEST_F(WrappableTest, GetAndSetProperty) {
" else obj.value = 191; })");
EXPECT_FALSE(source.IsEmpty());
- gin::TryCatch try_catch;
+ gin::TryCatch try_catch(isolate);
v8::Local<v8::Script> script = v8::Script::Compile(source);
EXPECT_FALSE(script.IsEmpty());
v8::Local<v8::Value> val = script->Run();
@@ -209,7 +209,7 @@ TEST_F(WrappableTest, WrappableSubclass) {
"(function(obj) {"
"obj.sayHello('Lily');"
"})");
- gin::TryCatch try_catch;
+ gin::TryCatch try_catch(isolate);
v8::Local<v8::Script> script = v8::Script::Compile(source);
v8::Local<v8::Value> val = script->Run();
v8::Local<v8::Function> func;
@@ -232,7 +232,7 @@ TEST_F(WrappableTest, CallAsFunction) {
"(function(obj) {"
"obj(42, 2, 5);"
"})");
- gin::TryCatch try_catch;
+ gin::TryCatch try_catch(isolate);
v8::Local<v8::Script> script = v8::Script::Compile(source);
v8::Local<v8::Value> val = script->Run();
v8::Local<v8::Function> func;
@@ -255,7 +255,7 @@ TEST_F(WrappableTest, CallAsConstructor) {
"(function(obj) {"
"new obj(42, 2, 5);"
"})");
- gin::TryCatch try_catch;
+ gin::TryCatch try_catch(isolate);
v8::Local<v8::Script> script = v8::Script::Compile(source);
v8::Local<v8::Value> val = script->Run();
v8::Local<v8::Function> func;
« no previous file with comments | « gin/wrappable.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698