Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: gin/modules/console.cc

Issue 1152653004: Re-land: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/modules/module_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/console.cc
diff --git a/gin/modules/console.cc b/gin/modules/console.cc
index d172373f01df2a0a2d194bfbc866e65f17015087..75241df081a7acd1f95fc8e2a87165890f4966e3 100644
--- a/gin/modules/console.cc
+++ b/gin/modules/console.cc
@@ -43,7 +43,7 @@ v8::Local<v8::Value> Console::GetModule(v8::Isolate* isolate) {
.Build();
data->SetObjectTemplate(&g_wrapper_info, templ);
}
- return templ->NewInstance();
+ return templ->NewInstance(isolate->GetCurrentContext()).ToLocalChecked();
}
} // namespace gin
« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/modules/module_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698