Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: gin/modules/console.cc

Issue 1152653004: Re-land: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/modules/module_registry.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/modules/console.h" 5 #include "gin/modules/console.h"
6 6
7 #include <iostream> 7 #include <iostream>
8 8
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "gin/arguments.h" 10 #include "gin/arguments.h"
(...skipping 25 matching lines...) Expand all
36 36
37 v8::Local<v8::Value> Console::GetModule(v8::Isolate* isolate) { 37 v8::Local<v8::Value> Console::GetModule(v8::Isolate* isolate) {
38 PerIsolateData* data = PerIsolateData::From(isolate); 38 PerIsolateData* data = PerIsolateData::From(isolate);
39 v8::Local<ObjectTemplate> templ = data->GetObjectTemplate(&g_wrapper_info); 39 v8::Local<ObjectTemplate> templ = data->GetObjectTemplate(&g_wrapper_info);
40 if (templ.IsEmpty()) { 40 if (templ.IsEmpty()) {
41 templ = ObjectTemplateBuilder(isolate) 41 templ = ObjectTemplateBuilder(isolate)
42 .SetMethod("log", Log) 42 .SetMethod("log", Log)
43 .Build(); 43 .Build();
44 data->SetObjectTemplate(&g_wrapper_info, templ); 44 data->SetObjectTemplate(&g_wrapper_info, templ);
45 } 45 }
46 return templ->NewInstance(); 46 return templ->NewInstance(isolate->GetCurrentContext()).ToLocalChecked();
47 } 47 }
48 48
49 } // namespace gin 49 } // namespace gin
OLDNEW
« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/modules/module_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698