Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: gin/interceptor_unittest.cc

Issue 1152653004: Re-land: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/dictionary.h ('k') | gin/modules/console.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/interceptor_unittest.cc
diff --git a/gin/interceptor_unittest.cc b/gin/interceptor_unittest.cc
index 01c6ba950c54bb35597b6215ed17d52fcc16617f..02fb10d235a7c9028790192d4e76d45696c10eb2 100644
--- a/gin/interceptor_unittest.cc
+++ b/gin/interceptor_unittest.cc
@@ -139,7 +139,7 @@ class InterceptorTest : public V8Test {
v8::Local<v8::String> source = StringToV8(isolate, script_source);
EXPECT_FALSE(source.IsEmpty());
- gin::TryCatch try_catch;
+ gin::TryCatch try_catch(isolate);
v8::Local<v8::Script> script = v8::Script::Compile(source);
EXPECT_FALSE(script.IsEmpty());
v8::Local<v8::Value> val = script->Run();
« no previous file with comments | « gin/dictionary.h ('k') | gin/modules/console.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698