Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1148763005: Remove support for PushSubscription.subscriptionId. (Closed)

Created:
5 years, 7 months ago by Peter Beverloo
Modified:
5 years, 6 months ago
Reviewers:
johnme, Mike West
CC:
blink-reviews, dglazkov+blink, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove support for PushSubscription.subscriptionId. The subscriptionId property has been included in endpoint for Chrome 44, and is to be removed in Chrome 45, per the following Intent: https://groups.google.com/a/chromium.org/d/topic/blink-dev/6OK5qm491Eg/discussion This CL is part of a three-sided patch: [1] This CL. [2] https://codereview.chromium.org/1154303003/ [3] https://codereview.chromium.org/1154233005/ BUG=477401 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196315

Patch Set 1 #

Patch Set 2 : Add a missing file. #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M LayoutTests/http/tests/push_messaging/get-subscription-in-document.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/get-subscription-in-service-worker.html View 3 chunks +9 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/push-subscription-stringification.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js View 2 chunks +2 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/subscribe-success-in-service-worker.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/push_messaging/unsubscribe-in-service-worker.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.h View 1 2 3 3 chunks +4 lines, -6 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.cpp View 1 2 4 chunks +4 lines, -8 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/exported/WebPushSubscription.cpp View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M public/platform/modules/push_messaging/WebPushSubscription.h View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Peter Beverloo
+johnme
5 years, 7 months ago (2015-05-27 15:13:26 UTC) #2
johnme
lgtm
5 years, 6 months ago (2015-05-28 11:30:31 UTC) #3
Peter Beverloo
+mkwst now that the Intent has been approved
5 years, 6 months ago (2015-05-29 12:35:17 UTC) #5
Mike West
LGTM % nit. https://codereview.chromium.org/1148763005/diff/20001/Source/platform/exported/WebPushSubscription.cpp File Source/platform/exported/WebPushSubscription.cpp (right): https://codereview.chromium.org/1148763005/diff/20001/Source/platform/exported/WebPushSubscription.cpp#newcode14 Source/platform/exported/WebPushSubscription.cpp:14: String concatenatedEndpoint = endpointWithoutSubscriptionId; Is this ...
5 years, 6 months ago (2015-06-02 04:40:53 UTC) #6
Peter Beverloo
Done. I've also removed the (now dead) UseCounter value and associated deprecation warning, and am ...
5 years, 6 months ago (2015-06-02 11:21:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148763005/60001
5 years, 6 months ago (2015-06-02 11:22:50 UTC) #10
Mike West
Still LGTM, thanks.
5 years, 6 months ago (2015-06-02 11:23:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64404)
5 years, 6 months ago (2015-06-02 13:13:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148763005/60001
5 years, 6 months ago (2015-06-02 13:18:40 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 14:04:38 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196315

Powered by Google App Engine
This is Rietveld 408576698