Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: Source/modules/push_messaging/PushSubscription.h

Issue 1148763005: Remove support for PushSubscription.subscriptionId. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | Source/modules/push_messaging/PushSubscription.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushSubscription.h
diff --git a/Source/modules/push_messaging/PushSubscription.h b/Source/modules/push_messaging/PushSubscription.h
index 8dbfd21350ba28cec11695c90fa50a232bbb49f7..e5a6305cfdc9dc9c89d8b4aacf7e4e15f4e10a83 100644
--- a/Source/modules/push_messaging/PushSubscription.h
+++ b/Source/modules/push_messaging/PushSubscription.h
@@ -9,7 +9,7 @@
#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
-#include "wtf/text/WTFString.h"
+#include "platform/weborigin/KURL.h"
namespace blink {
@@ -26,8 +26,7 @@ public:
virtual ~PushSubscription();
- String endpoint() const;
- const String& subscriptionId() const { return m_subscriptionId; }
+ KURL endpoint() const;
ScriptPromise unsubscribe(ScriptState*);
ScriptValue toJSONForBinding(ScriptState*);
@@ -35,10 +34,9 @@ public:
DECLARE_TRACE();
private:
- PushSubscription(const String& endpoint, const String& subscriptionId, ServiceWorkerRegistration*);
+ PushSubscription(const KURL& endpoint, ServiceWorkerRegistration*);
- String m_endpoint;
- String m_subscriptionId;
+ KURL m_endpoint;
Member<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | Source/modules/push_messaging/PushSubscription.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698