Source/platform/exported/WebPushSubscription.cpp - Issue 1148763005: Remove support for PushSubscription.subscriptionId.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/exported/WebPushSubscription.cpp

Issue 1148763005: Remove support for PushSubscription.subscriptionId. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a missing file. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "public/platform/modules/push_messaging/WebPushSubscription.h"

	7

	8 #include "wtf/text/WTFString.h"

	9

	10 namespace blink {

	11

	12 WebPushSubscription::WebPushSubscription(const WebString& endpointWithoutSubscri ptionId, const WebString& subscriptionId)

	13 {

	14 String concatenatedEndpoint = endpointWithoutSubscriptionId;
	Mike West 2015/06/02 04:40:53 Is this supposed to be a URL? Why store it as a st Is this supposed to be a URL? Why store it as a string? Peter Beverloo 2015/06/02 11:21:40 I like it! Done, thanks Mike! Show quoted text On 2015/06/02 04:40:53, Mike West wrote: > Is this supposed to be a URL? Why store it as a string? I like it! Done, thanks Mike!
	15 concatenatedEndpoint.append("/");

	16 concatenatedEndpoint.append(subscriptionId);

	17

	18 endpoint = concatenatedEndpoint;

	19 }

	20

	21 } // namespace blink

OLD	NEW