Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1154303003: Move push endpoint concatenation up to the browser process. (Closed)

Created:
5 years, 7 months ago by Peter Beverloo
Modified:
5 years, 6 months ago
Reviewers:
johnme, Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, johnme+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move push endpoint concatenation up to the browser process. The renderer no longer needs to know about the subscription id independent of the endpoint, so we can concatenate the endpoint and the subscription id before sending it to the renderer. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1148763005/ [2] This CL. [3] https://codereview.chromium.org/1154233005/ BUG=477401 Committed: https://crrev.com/109e5107e8db6ed12f0b9a903c87cdc485d29365 Cr-Commit-Position: refs/heads/master@{#332602}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -42 lines) Patch
M content/browser/push_messaging/push_messaging_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 1 2 6 chunks +18 lines, -8 lines 0 comments Download
M content/child/push_messaging/push_provider.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/child/push_messaging/push_provider.cc View 1 2 chunks +4 lines, -10 lines 0 comments Download
M content/common/push_messaging_messages.h View 2 chunks +6 lines, -9 lines 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.cc View 1 2 4 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Beverloo
+johnme
5 years, 7 months ago (2015-05-27 15:13:46 UTC) #2
johnme
lgtm
5 years, 6 months ago (2015-05-28 12:13:49 UTC) #3
Peter Beverloo
+mkwst
5 years, 6 months ago (2015-05-29 12:35:47 UTC) #5
Mike West
Dropping the ID in IPC LGTM.
5 years, 6 months ago (2015-06-02 04:43:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154303003/40001
5 years, 6 months ago (2015-06-03 12:22:16 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 12:25:48 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 12:26:36 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/109e5107e8db6ed12f0b9a903c87cdc485d29365
Cr-Commit-Position: refs/heads/master@{#332602}

Powered by Google App Engine
This is Rietveld 408576698