Issue 1154233005: Clean up left-overs of PushSubscription.subscriptionId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1154233005: Clean up left-overs of PushSubscription.subscriptionId. (Closed)

Created:
5 years, 6 months ago by Peter Beverloo

Modified:
5 years, 3 months ago

Reviewers:
johnme, Mike West

CC:
blink-reviews, dglazkov+blink, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Clean up left-overs of PushSubscription.subscriptionId. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1148763005/ [2] https://codereview.chromium.org/1154303003/ [3] This CL. BUG=477401

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -26 lines)			Patch
M	Source/platform/blink_platform.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/platform/exported/WebPushSubscription.cpp	View	1	1 chunk	+0 lines, -22 lines	0 comments	Download
M	public/platform/modules/push_messaging/WebPushSubscription.h	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 9 (2 generated)

Peter Beverloo

5 years, 3 months ago (2015-09-16 21:32:39 UTC) #9

On 2015/09/16 21:05:02, kbalazs wrote:
> Can this land? :)

I think John landed this as part of another CL. Closing - thanks for the ping!
:)