Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: Source/modules/push_messaging/PushSubscription.cpp

Issue 1148763005: Remove support for PushSubscription.subscriptionId. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/push_messaging/PushSubscription.h" 6 #include "modules/push_messaging/PushSubscription.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "bindings/core/v8/V8ObjectBuilder.h" 10 #include "bindings/core/v8/V8ObjectBuilder.h"
11 #include "modules/push_messaging/PushError.h" 11 #include "modules/push_messaging/PushError.h"
12 #include "modules/serviceworkers/ServiceWorkerRegistration.h" 12 #include "modules/serviceworkers/ServiceWorkerRegistration.h"
13 #include "public/platform/Platform.h" 13 #include "public/platform/Platform.h"
14 #include "public/platform/modules/push_messaging/WebPushProvider.h" 14 #include "public/platform/modules/push_messaging/WebPushProvider.h"
15 #include "public/platform/modules/push_messaging/WebPushSubscription.h" 15 #include "public/platform/modules/push_messaging/WebPushSubscription.h"
16 #include "wtf/OwnPtr.h" 16 #include "wtf/OwnPtr.h"
17 17
18 namespace blink { 18 namespace blink {
19 19
20 PushSubscription* PushSubscription::take(ScriptPromiseResolver*, WebPushSubscrip tion* pushSubscription, ServiceWorkerRegistration* serviceWorkerRegistration) 20 PushSubscription* PushSubscription::take(ScriptPromiseResolver*, WebPushSubscrip tion* pushSubscription, ServiceWorkerRegistration* serviceWorkerRegistration)
21 { 21 {
22 OwnPtr<WebPushSubscription> subscription = adoptPtr(pushSubscription); 22 OwnPtr<WebPushSubscription> subscription = adoptPtr(pushSubscription);
23 return new PushSubscription(subscription->endpoint, subscription->subscripti onId, serviceWorkerRegistration); 23 return new PushSubscription(subscription->endpoint, serviceWorkerRegistratio n);
24 } 24 }
25 25
26 void PushSubscription::dispose(WebPushSubscription* pushSubscription) 26 void PushSubscription::dispose(WebPushSubscription* pushSubscription)
27 { 27 {
28 if (pushSubscription) 28 if (pushSubscription)
29 delete pushSubscription; 29 delete pushSubscription;
30 } 30 }
31 31
32 PushSubscription::PushSubscription(const String& endpoint, const String& subscri ptionId, ServiceWorkerRegistration* serviceWorkerRegistration) 32 PushSubscription::PushSubscription(const KURL& endpoint, ServiceWorkerRegistrati on* serviceWorkerRegistration)
33 : m_endpoint(endpoint) 33 : m_endpoint(endpoint)
34 , m_subscriptionId(subscriptionId)
35 , m_serviceWorkerRegistration(serviceWorkerRegistration) 34 , m_serviceWorkerRegistration(serviceWorkerRegistration)
36 { 35 {
37 } 36 }
38 37
39 PushSubscription::~PushSubscription() 38 PushSubscription::~PushSubscription()
40 { 39 {
41 } 40 }
42 41
43 String PushSubscription::endpoint() const 42 KURL PushSubscription::endpoint() const
44 { 43 {
45 // TODO(peter): Remove all plumbing which separates the endpoint from the su bscriptionId 44 return m_endpoint;
46 // after the deprecation period has finished. https://crbug.com/477401.
47 return m_endpoint + "/" + m_subscriptionId;
48 } 45 }
49 46
50 ScriptPromise PushSubscription::unsubscribe(ScriptState* scriptState) 47 ScriptPromise PushSubscription::unsubscribe(ScriptState* scriptState)
51 { 48 {
52 RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver:: create(scriptState); 49 RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver:: create(scriptState);
53 ScriptPromise promise = resolver->promise(); 50 ScriptPromise promise = resolver->promise();
54 51
55 WebPushProvider* webPushProvider = Platform::current()->pushProvider(); 52 WebPushProvider* webPushProvider = Platform::current()->pushProvider();
56 ASSERT(webPushProvider); 53 ASSERT(webPushProvider);
57 54
58 webPushProvider->unsubscribe(m_serviceWorkerRegistration->webRegistration(), new CallbackPromiseAdapter<bool, PushError>(resolver)); 55 webPushProvider->unsubscribe(m_serviceWorkerRegistration->webRegistration(), new CallbackPromiseAdapter<bool, PushError>(resolver));
59 return promise; 56 return promise;
60 } 57 }
61 58
62 ScriptValue PushSubscription::toJSONForBinding(ScriptState* scriptState) 59 ScriptValue PushSubscription::toJSONForBinding(ScriptState* scriptState)
63 { 60 {
64 V8ObjectBuilder result(scriptState); 61 V8ObjectBuilder result(scriptState);
65 result.addString("endpoint", endpoint()); 62 result.addString("endpoint", endpoint());
66 result.addString("subscriptionId", subscriptionId());
67 63
68 return result.scriptValue(); 64 return result.scriptValue();
69 } 65 }
70 66
71 DEFINE_TRACE(PushSubscription) 67 DEFINE_TRACE(PushSubscription)
72 { 68 {
73 visitor->trace(m_serviceWorkerRegistration); 69 visitor->trace(m_serviceWorkerRegistration);
74 } 70 }
75 71
76 } // namespace blink 72 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/push_messaging/PushSubscription.h ('k') | Source/modules/push_messaging/PushSubscription.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698