Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: Source/modules/push_messaging/PushSubscription.cpp

Issue 1148763005: Remove support for PushSubscription.subscriptionId. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushSubscription.cpp
diff --git a/Source/modules/push_messaging/PushSubscription.cpp b/Source/modules/push_messaging/PushSubscription.cpp
index 5d1597545e8abda984d0c3cee2a5aa44c0bcc191..e006eeaa4591de35bd57d46cbb36c09ea41362a5 100644
--- a/Source/modules/push_messaging/PushSubscription.cpp
+++ b/Source/modules/push_messaging/PushSubscription.cpp
@@ -20,7 +20,7 @@ namespace blink {
PushSubscription* PushSubscription::take(ScriptPromiseResolver*, WebPushSubscription* pushSubscription, ServiceWorkerRegistration* serviceWorkerRegistration)
{
OwnPtr<WebPushSubscription> subscription = adoptPtr(pushSubscription);
- return new PushSubscription(subscription->endpoint, subscription->subscriptionId, serviceWorkerRegistration);
+ return new PushSubscription(subscription->endpoint, serviceWorkerRegistration);
}
void PushSubscription::dispose(WebPushSubscription* pushSubscription)
@@ -29,9 +29,8 @@ void PushSubscription::dispose(WebPushSubscription* pushSubscription)
delete pushSubscription;
}
-PushSubscription::PushSubscription(const String& endpoint, const String& subscriptionId, ServiceWorkerRegistration* serviceWorkerRegistration)
+PushSubscription::PushSubscription(const KURL& endpoint, ServiceWorkerRegistration* serviceWorkerRegistration)
: m_endpoint(endpoint)
- , m_subscriptionId(subscriptionId)
, m_serviceWorkerRegistration(serviceWorkerRegistration)
{
}
@@ -40,11 +39,9 @@ PushSubscription::~PushSubscription()
{
}
-String PushSubscription::endpoint() const
+KURL PushSubscription::endpoint() const
{
- // TODO(peter): Remove all plumbing which separates the endpoint from the subscriptionId
- // after the deprecation period has finished. https://crbug.com/477401.
- return m_endpoint + "/" + m_subscriptionId;
+ return m_endpoint;
}
ScriptPromise PushSubscription::unsubscribe(ScriptState* scriptState)
@@ -63,7 +60,6 @@ ScriptValue PushSubscription::toJSONForBinding(ScriptState* scriptState)
{
V8ObjectBuilder result(scriptState);
result.addString("endpoint", endpoint());
- result.addString("subscriptionId", subscriptionId());
return result.scriptValue();
}
« no previous file with comments | « Source/modules/push_messaging/PushSubscription.h ('k') | Source/modules/push_messaging/PushSubscription.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698