Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1144523003: Rename cc::ResourceProvider::ResourceId to cc::ResourceId and move it to its own file. (Closed)

Created:
5 years, 7 months ago by jbauman
Modified:
5 years, 7 months ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cc::ResourceProvider::ResourceId to cc::ResourceId and move it to its own file. This allows files like surface_resource_holder.h and transferable_resource.h to depend on the typedef without depending on resource_provider.h Committed: https://crrev.com/bbd425e075be8416cdc1d83a0b3907c17194a6ae Cr-Commit-Position: refs/heads/master@{#330459}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : Move to cc/base/resource_id.h #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -454 lines) Patch
M cc/base/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A cc/base/resource_id.h View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/delegated_frame_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 2 3 4 5 6 7 4 chunks +9 lines, -13 lines 0 comments Download
M cc/layers/tiled_layer_impl_unittest.cc View 1 2 3 4 5 6 7 5 chunks +9 lines, -11 lines 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -6 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -7 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 4 chunks +5 lines, -8 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 8 chunks +30 lines, -38 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M cc/quads/draw_quad.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/draw_quad_unittest.cc View 1 2 9 chunks +15 lines, -16 lines 0 comments Download
M cc/quads/render_pass_draw_quad.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/quads/render_pass_draw_quad.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/prioritized_resource.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/resources/prioritized_resource_manager.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/resources/resource.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/resource_provider.h View 1 2 3 4 5 11 chunks +11 lines, -11 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 14 chunks +28 lines, -32 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 63 chunks +109 lines, -128 lines 0 comments Download
M cc/resources/returned_resource.h View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/transferable_resource.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 21 chunks +29 lines, -29 lines 0 comments Download
M cc/surfaces/surface_resource_holder.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_resource_holder.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_delegated_renderer_layer_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/test/fake_ui_resource_layer_tree_host_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_ui_resource_layer_tree_host_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/test/render_pass_test_common.cc View 1 2 3 chunks +10 lines, -11 lines 0 comments Download
M cc/test/render_pass_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_draw_info.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_delegated.cc View 1 2 3 4 5 6 7 5 chunks +10 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jbauman
5 years, 7 months ago (2015-05-15 02:07:45 UTC) #2
danakj
LGTM https://codereview.chromium.org/1144523003/diff/60001/cc/resources/resource_id.h File cc/resources/resource_id.h (right): https://codereview.chromium.org/1144523003/diff/60001/cc/resources/resource_id.h#newcode10 cc/resources/resource_id.h:10: using ResourceId = unsigned; nit: can you uint32_t ...
5 years, 7 months ago (2015-05-15 17:19:35 UTC) #3
jbauman
On 2015/05/15 17:19:35, danakj wrote: > LGTM > > https://codereview.chromium.org/1144523003/diff/60001/cc/resources/resource_id.h > File cc/resources/resource_id.h (right): > ...
5 years, 7 months ago (2015-05-15 22:27:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144523003/120001
5 years, 7 months ago (2015-05-18 22:46:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/54630) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-18 22:57:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144523003/140001
5 years, 7 months ago (2015-05-19 00:20:28 UTC) #12
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 7 months ago (2015-05-19 00:33:44 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:34:42 UTC) #14
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/bbd425e075be8416cdc1d83a0b3907c17194a6ae
Cr-Commit-Position: refs/heads/master@{#330459}

Powered by Google App Engine
This is Rietveld 408576698