Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1142003003: Revert of Move copy-surface-as-draw fallback to GrGLGpu. (Closed)

Created:
5 years, 7 months ago by mtklein
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vares
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move copy-surface-as-draw fallback to GrGLGpu. (patchset #12 id:220001 of https://codereview.chromium.org/1144433002/) Reason for revert: Many GMs changed, some totally busted. Original issue's description: > Move copy-surface-as-draw fallback to GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/5df6fee929823f50c55cc50f7c882a309c1b1de9 TBR=joshualitt@google.com,egdaniel@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/404b3b264b833eb7cffdc833c7e2ebbd708e123a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -464 lines) Patch
M src/gpu/GrDrawTarget.h View 1 chunk +14 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +58 lines, -9 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 3 chunks +0 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 6 chunks +7 lines, -35 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 10 chunks +132 lines, -345 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 4 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 2 chunks +23 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
Created Revert of Move copy-surface-as-draw fallback to GrGLGpu.
5 years, 7 months ago (2015-05-18 16:28:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142003003/1
5 years, 7 months ago (2015-05-18 16:28:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/404b3b264b833eb7cffdc833c7e2ebbd708e123a
5 years, 7 months ago (2015-05-18 16:29:17 UTC) #3
mtklein
5 years, 7 months ago (2015-05-18 16:30:45 UTC) #4
Message was sent while issue was closed.
Some of the worst are the S4 on xfermodes, xfermodes3, hairmodes.

Powered by Google App Engine
This is Rietveld 408576698