Chromium Code Reviews

Issue 1133163005: MIPS64: Enable shorten-64-to-32 warning. (Closed)

Created:
5 years, 7 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
Reviewers:
Sven Panne, Michael Achenbach, dusmil.imgtec, danno, martyn.capewell, akos.palfi.imgtec, Jakob Kummerow, paul.l...
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Enable shorten-64-to-32 warning. Port cdc43bc5fd02fff2905e2e28a79054d0d1eee3ea Original commit message: Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings that arise. BUG= Committed: https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb Cr-Commit-Position: refs/heads/master@{#28990}

Patch Set 1 #

Patch Set 2 : Fix a function signature. #

Patch Set 3 : Fixes to 64 bits. #

Patch Set 4 : Modifications for MIPS32. #

Patch Set 5 : Rebase. #

Patch Set 6 : Fix alu_out usage. #

Patch Set 7 : Add the flag in gyp to xcode warnings. #

Patch Set 8 : Indentaion and mac related fix. #

Patch Set 9 : Remove modifications for MIPS32. #

Patch Set 10 : Use int32_t for register indexes. #

Patch Set 11 : Rebase and minor fixes. #

Total comments: 1

Patch Set 12 : Fix type related to mach_timespec. #

Unified diffs Side-by-side diffs Stats (+233 lines, -204 lines)
M build/standalone.gypi View 2 chunks +8 lines, -1 line 0 comments
M src/base/platform/time.cc View 1 chunk +1 line, -1 line 0 comments
M src/compiler/mips64/code-generator-mips64.cc View 9 chunks +25 lines, -18 lines 0 comments
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +7 lines, -7 lines 0 comments
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +4 lines, -2 lines 0 comments
M src/mips64/assembler-mips64.h View 2 chunks +5 lines, -3 lines 0 comments
M src/mips64/assembler-mips64.cc View 6 chunks +11 lines, -8 lines 0 comments
M src/mips64/disasm-mips64.cc View 1 chunk +1 line, -1 line 0 comments
M src/mips64/lithium-codegen-mips64.h View 1 chunk +1 line, -1 line 0 comments
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/mips64/macro-assembler-mips64.cc View 22 chunks +33 lines, -29 lines 0 comments
M src/mips64/simulator-mips64.h View 3 chunks +41 lines, -41 lines 0 comments
M src/mips64/simulator-mips64.cc View 29 chunks +86 lines, -85 lines 0 comments
M test/cctest/test-assembler-mips64.cc View 2 chunks +6 lines, -4 lines 0 comments
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +2 lines, -1 line 0 comments

Messages

Total messages: 13 (6 generated)
balazs.kilvady
5 years, 7 months ago (2015-05-19 18:40:23 UTC) #2
paul.l...
LGTM. This does need a v8-team review on a standlone.gypi and platform/time.cc as well. Can ...
5 years, 6 months ago (2015-06-11 18:39:19 UTC) #5
Sven Panne
LGTM with a nit (didn't really look at the platform-dependent parts) https://codereview.chromium.org/1133163005/diff/220001/src/base/platform/time.cc File src/base/platform/time.cc (right): ...
5 years, 6 months ago (2015-06-12 07:06:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133163005/240001
5 years, 6 months ago (2015-06-12 09:18:02 UTC) #10
commit-bot: I haz the power
Committed patchset #12 (id:240001)
5 years, 6 months ago (2015-06-12 09:39:58 UTC) #11
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb Cr-Commit-Position: refs/heads/master@{#28990}
5 years, 6 months ago (2015-06-12 09:40:13 UTC) #12
Yang
5 years, 6 months ago (2015-06-12 09:58:01 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #12 id:240001) has been created in
https://codereview.chromium.org/1182493007/ by yangguo@chromium.org.

The reason for reverting is: Compile failure:
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/....

Powered by Google App Engine