src/mips64/disasm-mips64.cc - Issue 1133163005: MIPS64: Enable shorten-64-to-32 warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/disasm-mips64.cc

Issue 1133163005: MIPS64: Enable shorten-64-to-32 warning. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix type related to mach_timespec. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips64/disasm-mips64.cc

diff --git a/src/mips64/disasm-mips64.cc b/src/mips64/disasm-mips64.cc

index b0b528fdc4e07833fd19d964c7d13a48d55403cb..1734913bfdda9bddaba97ebec0800f9114d2962a 100644

--- a/src/mips64/disasm-mips64.cc

+++ b/src/mips64/disasm-mips64.cc

@@ -272,7 +272,7 @@ void Decoder::PrintXImm21(Instruction* instr) {

// Print 26-bit immediate value.

void Decoder::PrintXImm26(Instruction* instr) {

- uint32_t imm = instr->Imm26Value() << kImmFieldShift;

+ uint32_t imm = static_cast<uint32_t>(instr->Imm26Value()) << kImmFieldShift;

out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_, "0x%x", imm);

}

« no previous file with comments | « src/mips64/assembler-mips64.cc ('k') | src/mips64/lithium-codegen-mips64.h » ('j') | no next file with comments »