Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124763003: Update from https://crrev.com/327068 (Closed)

Created:
5 years, 7 months ago by jamesr
Modified:
5 years, 7 months ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update from https://crrev.com/327068 This rolls in //base, //build and //sandbox/linux and updates other things to match, in particular: *) Update build_v8.patch *) Add junit, mockito and roboelectric to DEPS for android test rules *) Update DEPS for grit *) Fix up various GN files for os->target_os rename *) Fix up a few places that were using //base/float_util to use std::isnan *) Fix up a few places using ApiCompatibilityUtil to use Android SDK directly as well as a few miscellaneous fixes. Many portions based on ncbray's work in https://codereview.chromium.org/1108173002/ R=ncbray@chromium.org TBR=ncbray@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0fae00061321666ab3a971dea67c1d1219918589

Patch Set 1 #

Patch Set 2 : update nacl, buildtools, fix display_change_notifier_unittest #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22262 lines, -13453 lines) Patch
M .gitignore View 1 1 chunk +3 lines, -0 lines 0 comments Download
M DEPS View 1 3 chunks +12 lines, -3 lines 0 comments Download
M base/BUILD.gn View 1 23 chunks +55 lines, -26 lines 0 comments Download
M base/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/android/base_jni_registrar.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M base/android/build_info.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
D base/android/java/src/org/chromium/base/AccessedByNative.java View 1 1 chunk +0 lines, -20 lines 0 comments Download
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 4 chunks +0 lines, -128 lines 0 comments Download
M base/android/java/src/org/chromium/base/ApplicationStatus.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 1 2 chunks +12 lines, -0 lines 0 comments Download
D base/android/java/src/org/chromium/base/CalledByNativeUnchecked.java View 1 1 chunk +0 lines, -27 lines 0 comments Download
A base/android/java/src/org/chromium/base/Log.java View 1 1 chunk +357 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/PackageUtils.java View 1 1 chunk +37 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 1 4 chunks +43 lines, -13 lines 0 comments Download
D base/android/java/src/org/chromium/base/UsedByReflection.java View 1 1 chunk +0 lines, -24 lines 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/AccessedByNative.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/CalledByNativeUnchecked.java View 1 1 chunk +1 line, -1 line 0 comments Download
A base/android/java/src/org/chromium/base/annotations/NoSideEffects.java View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/UsedByReflection.java View 1 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 1 3 chunks +10 lines, -3 lines 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 1 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/metrics/RecordHistogram.java View 1 3 chunks +41 lines, -4 lines 0 comments Download
A base/android/java/src/org/chromium/base/metrics/RecordUserAction.java View 1 1 chunk +36 lines, -0 lines 0 comments Download
A base/android/java_runtime.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A base/android/java_runtime.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
A base/android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java View 1 1 chunk +71 lines, -0 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/ObserverListTest.java View 1 5 chunks +4 lines, -9 lines 0 comments Download
M base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
A base/android/junit/src/org/chromium/base/LogTest.java View 1 1 chunk +93 lines, -0 lines 0 comments Download
M base/android/linker/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/android/linker/linker_jni.cc View 1 3 chunks +66 lines, -0 lines 0 comments Download
M base/android/record_histogram.cc View 1 3 chunks +50 lines, -20 lines 0 comments Download
A + base/android/record_user_action.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
A base/android/record_user_action.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M base/async_socket_io_handler.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/base.gyp View 1 19 chunks +85 lines, -66 lines 0 comments Download
M base/base.gypi View 1 9 chunks +12 lines, -10 lines 0 comments Download
M base/base.isolate View 1 2 chunks +2 lines, -7 lines 0 comments Download
M base/base_nacl.gyp View 1 3 chunks +0 lines, -5 lines 0 comments Download
M base/base_unittests.isolate View 1 1 chunk +7 lines, -0 lines 0 comments Download
M base/bind_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + base/chromeos/memory_pressure_monitor_chromeos.h View 1 5 chunks +19 lines, -15 lines 0 comments Download
A + base/chromeos/memory_pressure_monitor_chromeos.cc View 1 8 chunks +75 lines, -22 lines 0 comments Download
A + base/chromeos/memory_pressure_monitor_chromeos_unittest.cc View 1 4 chunks +28 lines, -28 lines 0 comments Download
D base/chromeos/memory_pressure_observer_chromeos.h View 1 1 chunk +0 lines, -109 lines 0 comments Download
D base/chromeos/memory_pressure_observer_chromeos.cc View 1 1 chunk +0 lines, -211 lines 0 comments Download
D base/chromeos/memory_pressure_observer_chromeos_unittest.cc View 1 1 chunk +0 lines, -164 lines 0 comments Download
M base/command_line.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M base/command_line.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M base/command_line_unittest.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M base/compiler_specific.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M base/file_version_info_win.h View 1 1 chunk +17 lines, -17 lines 0 comments Download
M base/files/file.h View 1 3 chunks +11 lines, -7 lines 0 comments Download
M base/files/file.cc View 1 5 chunks +10 lines, -11 lines 0 comments Download
M base/files/file_path.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M base/files/file_path_watcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D base/files/file_path_watcher_browsertest.cc View 1 1 chunk +0 lines, -871 lines 0 comments Download
M base/files/file_path_watcher_fsevents.h View 1 2 chunks +34 lines, -13 lines 0 comments Download
M base/files/file_path_watcher_fsevents.cc View 1 6 chunks +91 lines, -71 lines 0 comments Download
M base/files/file_path_watcher_stub.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + base/files/file_path_watcher_unittest.cc View 1 5 chunks +37 lines, -0 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M base/files/file_posix.cc View 1 15 chunks +116 lines, -133 lines 0 comments Download
D base/files/file_posix_hooks_internal.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
M base/files/file_util_posix.cc View 1 5 chunks +4 lines, -2 lines 0 comments Download
M base/files/file_win.cc View 1 12 chunks +104 lines, -104 lines 0 comments Download
D base/files/protect_file_posix.cc View 1 1 chunk +0 lines, -106 lines 0 comments Download
D base/files/protect_file_posix.gypi View 1 1 chunk +0 lines, -31 lines 0 comments Download
D base/float_util.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
M base/i18n/file_util_icu.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M base/i18n/icu_util.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/icu_util.cc View 1 6 chunks +23 lines, -0 lines 0 comments Download
M base/i18n/string_compare.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M base/i18n/string_compare.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M base/json/json_parser.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M base/json/json_value_converter.h View 1 7 chunks +10 lines, -14 lines 0 comments Download
M base/logging_win.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/mac/close_nocancel.cc View 1 2 chunks +11 lines, -20 lines 0 comments Download
M base/md5.h View 1 3 chunks +7 lines, -5 lines 0 comments Download
M base/md5.cc View 1 7 chunks +189 lines, -194 lines 0 comments Download
M base/memory/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/discardable_memory.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M base/memory/discardable_shared_memory.h View 1 3 chunks +12 lines, -6 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 1 2 chunks +20 lines, -16 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M base/memory/manual_constructor.h View 1 4 chunks +6 lines, -60 lines 0 comments Download
A base/memory/memory_pressure_monitor.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A base/memory/memory_pressure_monitor.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M base/memory/ref_counted.h View 1 5 chunks +20 lines, -0 lines 0 comments Download
M base/memory/ref_counted_delete_on_message_loop.h View 1 4 chunks +13 lines, -6 lines 0 comments Download
M base/memory/ref_counted_unittest.cc View 1 3 chunks +352 lines, -5 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_libevent.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 1 5 chunks +70 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_win.h View 1 4 chunks +10 lines, -11 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M base/metrics/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M base/move.h View 1 2 chunks +9 lines, -4 lines 0 comments Download
A base/move_unittest.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
A base/native_library_ios.mm View 1 1 chunk +40 lines, -0 lines 0 comments Download
M base/observer_list.h View 1 5 chunks +9 lines, -7 lines 0 comments Download
M base/observer_list_threadsafe.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M base/observer_list_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/prefs/pref_member.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M base/prefs/pref_registry.h View 1 3 chunks +25 lines, -2 lines 0 comments Download
M base/prefs/pref_registry.cc View 1 3 chunks +14 lines, -1 line 0 comments Download
M base/prefs/pref_registry_simple.h View 1 1 chunk +40 lines, -1 line 0 comments Download
M base/prefs/pref_registry_simple.cc View 1 1 chunk +106 lines, -11 lines 0 comments Download
M base/prefs/pref_value_map.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M base/prefs/pref_value_map.cc View 1 7 chunks +40 lines, -35 lines 0 comments Download
M base/process/kill.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M base/process/kill.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_posix.cc View 1 2 chunks +0 lines, -56 lines 0 comments Download
M base/process/kill_win.cc View 1 3 chunks +3 lines, -15 lines 0 comments Download
M base/process/launch_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/process/memory.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M base/process/memory.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M base/process/memory_mac.mm View 1 15 chunks +15 lines, -15 lines 0 comments Download
M base/process/memory_unittest.cc View 1 18 chunks +34 lines, -60 lines 0 comments Download
M base/process/process.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M base/process/process_metrics_ios.cc View 1 3 chunks +13 lines, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/process/process_posix.cc View 1 3 chunks +54 lines, -5 lines 0 comments Download
M base/process/process_win.cc View 1 2 chunks +13 lines, -3 lines 0 comments Download
A base/profiler/native_stack_sampler.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A base/profiler/native_stack_sampler.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M base/profiler/scoped_profile.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M base/profiler/stack_sampling_profiler.h View 1 4 chunks +129 lines, -71 lines 0 comments Download
M base/profiler/stack_sampling_profiler.cc View 1 5 chunks +165 lines, -115 lines 0 comments Download
M base/profiler/stack_sampling_profiler_posix.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/profiler/stack_sampling_profiler_unittest.cc View 1 8 chunks +207 lines, -83 lines 0 comments Download
M base/profiler/stack_sampling_profiler_win.cc View 1 4 chunks +202 lines, -170 lines 0 comments Download
M base/security_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/stl_util.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M base/strings/string_split.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M base/sync_socket.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M base/synchronization/cancellation_flag.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M base/synchronization/cancellation_flag.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M base/synchronization/condition_variable_win.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
M base/synchronization/waitable_event_unittest.cc View 1 3 chunks +37 lines, -17 lines 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_win.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M base/sys_info.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M base/sys_info_android.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M base/sys_info_chromeos.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M base/sys_info_freebsd.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M base/sys_info_ios.mm View 1 1 chunk +0 lines, -6 lines 0 comments Download
M base/sys_info_linux.cc View 1 4 chunks +5 lines, -14 lines 0 comments Download
M base/sys_info_mac.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M base/sys_info_openbsd.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M base/sys_info_unittest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M base/sys_info_win.cc View 1 2 chunks +1 line, -41 lines 0 comments Download
M base/test/BUILD.gn View 1 3 chunks +16 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java View 1 2 chunks +8 lines, -8 lines 0 comments Download
M base/test/gtest_xml_util.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + base/test/ios/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A base/test/ios/wait_util.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A base/test/ios/wait_util.mm View 1 1 chunk +62 lines, -0 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A base/test/malloc_wrapper.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + base/test/malloc_wrapper.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
A base/test/mock_entropy_provider.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A base/test/mock_entropy_provider.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/test/test_discardable_memory_allocator.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/test/test_mock_time_task_runner.h View 1 2 chunks +11 lines, -4 lines 0 comments Download
M base/test/test_mock_time_task_runner.cc View 1 2 chunks +46 lines, -5 lines 0 comments Download
M base/test/test_reg_util_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A base/test/user_action_tester.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A base/test/user_action_tester.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download
A base/test/user_action_tester_unittest.cc View 1 1 chunk +86 lines, -0 lines 0 comments Download
D base/third_party/nspr/BUILD.gn View 1 1 chunk +0 lines, -21 lines 0 comments Download
M base/third_party/xdg_mime/README.chromium View 1 1 chunk +4 lines, -2 lines 0 comments Download
A base/third_party/xdg_mime/free_pointer_later.patch View 1 1 chunk +22 lines, -0 lines 0 comments Download
M base/third_party/xdg_mime/xdgmime.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
M base/threading/platform_thread.h View 1 4 chunks +17 lines, -12 lines 0 comments Download
M base/threading/platform_thread_android.cc View 1 3 chunks +14 lines, -8 lines 0 comments Download
M base/threading/platform_thread_freebsd.cc View 1 1 chunk +27 lines, -7 lines 0 comments Download
M base/threading/platform_thread_internal_posix.h View 1 1 chunk +12 lines, -2 lines 0 comments Download
M base/threading/platform_thread_internal_posix.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M base/threading/platform_thread_linux.cc View 1 1 chunk +27 lines, -7 lines 0 comments Download
M base/threading/platform_thread_mac.mm View 1 2 chunks +8 lines, -2 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 1 6 chunks +40 lines, -7 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 1 5 chunks +169 lines, -13 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 2 chunks +46 lines, -8 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 8 chunks +43 lines, -30 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 3 chunks +39 lines, -1 line 0 comments Download
M base/threading/thread.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M base/threading/thread_local_storage_unittest.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M base/threading/thread_local_unittest.cc View 1 8 chunks +11 lines, -12 lines 0 comments Download
M base/threading/thread_perftest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/threading/thread_restrictions.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M base/time/time.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/BUILD.gn View 1 7 chunks +24 lines, -1 line 0 comments Download
M base/trace_event/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A base/trace_event/etw_manifest/BUILD.gn View 1 1 chunk +37 lines, -0 lines 0 comments Download
A base/trace_event/etw_manifest/BUILD/message_compiler.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
A base/trace_event/etw_manifest/chrome_events_win.man View 1 1 chunk +84 lines, -0 lines 0 comments Download
A base/trace_event/etw_manifest/etw_manifest.gyp View 1 1 chunk +39 lines, -0 lines 0 comments Download
A base/trace_event/java_heap_dump_provider_android.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A base/trace_event/java_heap_dump_provider_android.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download
A base/trace_event/malloc_dump_provider.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A base/trace_event/malloc_dump_provider.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
D base/trace_event/memory_allocator_attributes.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
A base/trace_event/memory_allocator_attributes_type_info.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A base/trace_event/memory_allocator_attributes_type_info.cc View 1 1 chunk +61 lines, -0 lines 0 comments Download
A base/trace_event/memory_allocator_attributes_type_info_unittest.cc View 1 1 chunk +59 lines, -0 lines 0 comments Download
M base/trace_event/memory_allocator_dump.h View 1 1 chunk +54 lines, -16 lines 0 comments Download
M base/trace_event/memory_allocator_dump.cc View 1 1 chunk +77 lines, -40 lines 0 comments Download
M base/trace_event/memory_allocator_dump_unittest.cc View 1 1 chunk +70 lines, -49 lines 0 comments Download
M base/trace_event/memory_dump_manager.h View 1 2 chunks +87 lines, -23 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 4 chunks +258 lines, -71 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 12 chunks +140 lines, -20 lines 0 comments Download
M base/trace_event/memory_dump_provider.h View 1 2 chunks +32 lines, -9 lines 0 comments Download
M base/trace_event/memory_dump_provider.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download
A base/trace_event/memory_dump_request_args.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A base/trace_event/memory_dump_session_state.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A base/trace_event/memory_dump_session_state.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M base/trace_event/process_memory_dump.h View 1 4 chunks +34 lines, -14 lines 0 comments Download
M base/trace_event/process_memory_dump.cc View 1 1 chunk +15 lines, -14 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/trace_event/process_memory_totals_dump_provider_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event.h View 1 3 chunks +12 lines, -5 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 4 chunks +21 lines, -1 line 0 comments Download
A base/trace_event/trace_event_etw_export_win.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A base/trace_event/trace_event_etw_export_win.cc View 1 1 chunk +239 lines, -0 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 1 6 chunks +12 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 1 14 chunks +45 lines, -13 lines 0 comments Download
M base/trace_event/trace_event_win_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A base/trace_event/winheap_dump_provider_win.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A base/trace_event/winheap_dump_provider_win.cc View 1 1 chunk +103 lines, -0 lines 0 comments Download
A base/trace_event/winheap_dump_provider_win_unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M base/tracked_objects.h View 1 7 chunks +51 lines, -23 lines 0 comments Download
M base/tracked_objects.cc View 1 14 chunks +57 lines, -68 lines 0 comments Download
M base/tracked_objects_unittest.cc View 1 8 chunks +158 lines, -100 lines 0 comments Download
M base/tuple.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M base/values.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/enum_variant.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download
M base/win/iunknown_impl.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/win/iunknown_impl_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M base/win/object_watcher.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/object_watcher_unittest.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M base/win/pe_image.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/win/pe_image.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M base/win/registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/win/registry_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/scoped_handle.cc View 1 3 chunks +140 lines, -43 lines 0 comments Download
M base/win/scoped_process_information.cc View 1 2 chunks +44 lines, -5 lines 0 comments Download
M base/win/shortcut.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M base/win/shortcut.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M base/win/shortcut_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M build/PRESUBMIT.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M build/all.gyp View 1 25 chunks +112 lines, -60 lines 0 comments Download
M build/android/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/PRESUBMIT.py View 1 3 chunks +1 line, -21 lines 0 comments Download
M build/android/adb_install_apk.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 1 2 chunks +8 lines, -6 lines 0 comments Download
D build/android/android_exports.gyp View 1 1 chunk +0 lines, -43 lines 0 comments Download
D build/android/android_webview_export_whitelist.lst View 1 1 chunk +0 lines, -16 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 15 chunks +101 lines, -93 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 4 chunks +8 lines, -5 lines 0 comments Download
M build/android/buildbot/bb_host_steps.py View 1 5 chunks +5 lines, -14 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 3 chunks +3 lines, -4 lines 0 comments Download
M build/android/cpufeatures.gypi View 1 1 chunk +7 lines, -24 lines 0 comments Download
M build/android/enable_asserts.py View 1 1 chunk +23 lines, -19 lines 0 comments Download
M build/android/finalize_apk_action.gypi View 1 1 chunk +2 lines, -10 lines 0 comments Download
A build/android/findbugs_action.gypi View 1 1 chunk +22 lines, -0 lines 0 comments Download
M build/android/findbugs_diff.py View 1 2 chunks +78 lines, -17 lines 0 comments Download
M build/android/findbugs_filter/findbugs_exclude.xml View 1 1 chunk +2 lines, -30 lines 0 comments Download
D build/android/gyp/jarjar_resources.py View 1 1 chunk +0 lines, -121 lines 0 comments Download
M build/android/gyp/jinja_template.py View 1 4 chunks +16 lines, -8 lines 0 comments Download
M build/android/gyp/process_resources.py View 1 2 chunks +5 lines, -3 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/util/build_utils.py View 1 3 chunks +4 lines, -2 lines 0 comments Download
M build/android/gyp/write_build_config.py View 1 6 chunks +60 lines, -4 lines 0 comments Download
M build/android/host_heartbeat.py View 1 2 chunks +4 lines, -5 lines 0 comments Download
M build/android/java_cpp_enum.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/provision_devices.py View 1 6 chunks +190 lines, -174 lines 0 comments Download
M build/android/pylib/base/base_test_runner.py View 1 3 chunks +1 line, -5 lines 0 comments Download
D build/android/pylib/constants.py View 1 1 chunk +0 lines, -293 lines 0 comments Download
A + build/android/pylib/constants/__init__.py View 1 4 chunks +12 lines, -2 lines 0 comments Download
A build/android/pylib/constants/keyevent.py View 1 1 chunk +14 lines, -0 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 5 chunks +26 lines, -3 lines 0 comments Download
M build/android/pylib/device/adb_wrapper_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
A build/android/pylib/device/battery_utils.py View 1 1 chunk +386 lines, -0 lines 0 comments Download
A build/android/pylib/device/battery_utils_test.py View 1 1 chunk +316 lines, -0 lines 0 comments Download
M build/android/pylib/device/decorators.py View 1 2 chunks +7 lines, -3 lines 0 comments Download
M build/android/pylib/device/device_errors.py View 1 2 chunks +12 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 1 16 chunks +137 lines, -194 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 12 chunks +204 lines, -170 lines 0 comments Download
A build/android/pylib/device_signal.py View 1 1 chunk +41 lines, -0 lines 0 comments Download
M build/android/pylib/forwarder.py View 1 2 chunks +4 lines, -7 lines 0 comments Download
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 1 chunk +0 lines, -7 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 1 2 chunks +3 lines, -7 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_options.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 3 chunks +14 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 1 3 chunks +15 lines, -17 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 3 chunks +8 lines, -3 lines 0 comments Download
M build/android/pylib/host_driven/setup.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 1 2 chunks +1 line, -6 lines 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 1 2 chunks +8 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_options.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 2 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/junit/test_dispatcher.py View 1 2 chunks +13 lines, -4 lines 0 comments Download
M build/android/pylib/junit/test_runner.py View 1 2 chunks +22 lines, -16 lines 0 comments Download
M build/android/pylib/linker/setup.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/linker/test_runner.py View 1 2 chunks +3 lines, -6 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 1 chunk +8 lines, -10 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 chunks +33 lines, -7 lines 0 comments Download
M build/android/pylib/monkey/test_runner.py View 1 2 chunks +14 lines, -3 lines 0 comments Download
M build/android/pylib/perf/perf_control.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 1 chunk +1 line, -1 line 0 comments Download
A build/android/pylib/remote/device/appurify_constants.py View 1 1 chunk +57 lines, -0 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_environment.py View 1 4 chunks +8 lines, -3 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 1 4 chunks +25 lines, -10 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 2 chunks +66 lines, -0 lines 0 comments Download
M build/android/pylib/screenshot.py View 1 3 chunks +13 lines, -5 lines 0 comments Download
M build/android/pylib/uiautomator/test_options.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/utils/emulator.py View 1 2 chunks +10 lines, -12 lines 0 comments Download
M build/android/pylib/utils/findbugs.py View 1 1 chunk +129 lines, -230 lines 0 comments Download
M build/android/pylib/utils/isolator.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M build/android/pylib/utils/md5sum.py View 1 7 chunks +14 lines, -6 lines 0 comments Download
M build/android/pylib/utils/md5sum_test.py View 1 6 chunks +65 lines, -20 lines 0 comments Download
M build/android/pylib/utils/mock_calls.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 1 chunk +10 lines, -9 lines 0 comments Download
M build/android/screenshot.py View 1 2 chunks +16 lines, -12 lines 0 comments Download
M build/android/test_runner.py View 1 6 chunks +13 lines, -7 lines 0 comments Download
M build/android/tombstones.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M build/android/update_verification.py View 1 6 chunks +8 lines, -13 lines 0 comments Download
M build/apk_test.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/build_config.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 53 chunks +378 lines, -315 lines 0 comments Download
M build/config/BUILD.gn View 1 3 chunks +21 lines, -8 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 4 chunks +4 lines, -30 lines 0 comments Download
M build/config/android/config.gni View 1 3 chunks +3 lines, -9 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 5 chunks +63 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 15 chunks +80 lines, -18 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 1 chunk +20 lines, -11 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 10 chunks +90 lines, -113 lines 0 comments Download
M build/config/crypto.gni View 1 1 chunk +9 lines, -6 lines 0 comments Download
M build/config/features.gni View 1 3 chunks +11 lines, -3 lines 0 comments Download
M build/config/gcc/gcc_version.gni View 1 1 chunk +1 line, -6 lines 0 comments Download
M build/config/linux/gtk/BUILD.gn View 1 2 chunks +5 lines, -2 lines 0 comments Download
M build/config/sysroot.gni View 1 1 chunk +12 lines, -16 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 chunks +23 lines, -16 lines 0 comments Download
D build/escape_unicode.py View 1 1 chunk +0 lines, -56 lines 0 comments Download
M build/gn_migration.gypi View 1 17 chunks +319 lines, -164 lines 0 comments Download
M build/grit_action.gypi View 1 1 chunk +3 lines, -2 lines 0 comments Download
M build/gyp_chromium View 1 2 chunks +3 lines, -3 lines 0 comments Download
M build/gyp_helper.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/host_jar.gypi View 1 3 chunks +32 lines, -3 lines 0 comments Download
M build/install-build-deps.sh View 1 2 chunks +7 lines, -1 line 0 comments Download
M build/ios/grit_whitelist.txt View 1 12 chunks +38 lines, -137 lines 0 comments Download
M build/isolate.gypi View 1 3 chunks +7 lines, -3 lines 0 comments Download
M build/jar_file_jni_generator.gypi View 1 1 chunk +0 lines, -10 lines 0 comments Download
M build/java.gypi View 1 2 chunks +27 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 2 chunks +28 lines, -0 lines 0 comments Download
M build/jni_generator.gypi View 1 1 chunk +0 lines, -10 lines 0 comments Download
D build/linux/install-arm-sysroot.py View 1 1 chunk +0 lines, -12 lines 0 comments Download
M build/linux/system.gyp View 1 4 chunks +20 lines, -11 lines 0 comments Download
M build/linux/unbundle/libvpx.gyp View 1 1 chunk +7 lines, -6 lines 0 comments Download
M build/protoc_java.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A build/sanitizers/asan_suppressions.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 1 4 chunks +12 lines, -14 lines 0 comments Download
M build/sanitizers/sanitizers.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/sanitizers/tsan_suppressions.cc View 1 6 chunks +7 lines, -12 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 2 chunks +8 lines, -1 line 0 comments Download
D build/secondary/third_party/leveldatabase/BUILD.gn View 1 1 chunk +0 lines, -338 lines 0 comments Download
D build/secondary/third_party/sfntly/BUILD.gn View 1 1 chunk +0 lines, -131 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 6 chunks +21 lines, -29 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 2 chunks +1 line, -4 lines 0 comments Download
M build/util/lastchange.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/task_tracker_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/dart/embedder/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/BUILD.gn View 1 2 chunks +2 lines, -2 lines 1 comment Download
M mojo/tools/mopy/gn.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/tools/mopy/gn_unittest.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/tools/roll/build_v8.patch View 1 1 chunk +3 lines, -4 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 3 chunks +8 lines, -6 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/codegen.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/codegen_unittest.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/dump_bpf.cc View 1 2 chunks +17 lines, -13 lines 0 comments Download
M sandbox/linux/bpf_dsl/linux_syscall_ranges.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/seccomp_macros.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/verifier.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/die.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 3 chunks +32 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_test_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 1 7 chunks +17 lines, -17 lines 0 comments Download
A sandbox/linux/seccomp-bpf/trap_unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M sandbox/linux/services/credentials.h View 1 2 chunks +18 lines, -10 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 1 10 chunks +41 lines, -26 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 1 3 chunks +12 lines, -9 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.h View 1 3 chunks +38 lines, -0 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.cc View 1 4 chunks +83 lines, -3 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox_unittest.cc View 1 2 chunks +94 lines, -0 lines 0 comments Download
M sandbox/linux/services/resource_limits.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/scoped_process.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/scoped_process.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/scoped_process_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.h View 1 2 chunks +22 lines, -0 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 1 3 chunks +146 lines, -2 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers_unittest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download
M sandbox/linux/services/thread_helpers.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/thread_helpers.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/thread_helpers_unittests.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/yama.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_process.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_process_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D sandbox/linux/system_headers/android_arm64_ucontext.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
D sandbox/linux/system_headers/android_arm_ucontext.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D sandbox/linux/system_headers/android_futex.h View 1 1 chunk +0 lines, -80 lines 0 comments Download
D sandbox/linux/system_headers/android_i386_ucontext.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
D sandbox/linux/system_headers/android_mips_ucontext.h View 1 1 chunk +0 lines, -51 lines 0 comments Download
D sandbox/linux/system_headers/android_ucontext.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
D sandbox/linux/system_headers/android_x86_64_ucontext.h View 1 1 chunk +0 lines, -88 lines 0 comments Download
A + sandbox/linux/system_headers/arm64_linux_ucontext.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/system_headers/arm_linux_syscalls.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
A sandbox/linux/system_headers/arm_linux_ucontext.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A + sandbox/linux/system_headers/i386_linux_ucontext.h View 1 2 chunks +15 lines, -1 line 0 comments Download
A sandbox/linux/system_headers/linux_filter.h View 1 1 chunk +140 lines, -0 lines 0 comments Download
A + sandbox/linux/system_headers/linux_futex.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M sandbox/linux/system_headers/linux_seccomp.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
A sandbox/linux/system_headers/linux_signal.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/linux_ucontext.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A + sandbox/linux/system_headers/mips_linux_ucontext.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/x86_64_linux_ucontext.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/tests/sandbox_test_runner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/tests/sandbox_test_runner_function_pointer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/tests/test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/tests/test_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/tests/unit_tests.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/SkDiscardableMemory_chrome.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/BUILD.gn View 1 1 chunk +1 line, -1 line 1 comment Download
M sky/shell/org/domokit/sky/shell/SkyApplication.java View 1 1 chunk +1 line, -1 line 0 comments Download
D testing/android/BUILD.gn View 1 1 chunk +0 lines, -43 lines 0 comments Download
D testing/android/README.chromium View 1 1 chunk +0 lines, -2 lines 0 comments Download
D testing/android/java/AndroidManifest.xml View 1 1 chunk +0 lines, -38 lines 0 comments Download
D testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 1 chunk +0 lines, -124 lines 0 comments Download
D testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 1 1 chunk +0 lines, -230 lines 0 comments Download
M testing/android/junit/BUILD.gn View 1 1 chunk +3 lines, -6 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/JsonListener.java View 1 1 chunk +54 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/JsonLogger.java View 1 1 chunk +89 lines, -0 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/JunitTestArgParser.java View 1 5 chunks +28 lines, -1 line 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/JunitTestMain.java View 1 4 chunks +22 lines, -9 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java View 1 2 chunks +1 line, -10 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/RobolectricClasspathDependencyResolver.java View 1 1 chunk +72 lines, -0 lines 0 comments Download
M testing/android/native_test.gyp View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + testing/android/native_test/BUILD.gn View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/README.chromium View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/java/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/native_test_jni_onload.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/native_test/native_test_launcher.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/native_test_launcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/native_test/native_test_util.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/native_test_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D testing/android/native_test_jni_onload.cc View 1 1 chunk +0 lines, -38 lines 0 comments Download
D testing/android/native_test_launcher.h View 1 1 chunk +0 lines, -13 lines 0 comments Download
D testing/android/native_test_launcher.cc View 1 1 chunk +0 lines, -161 lines 0 comments Download
D testing/android/native_test_util.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
D testing/android/native_test_util.cc View 1 1 chunk +0 lines, -50 lines 0 comments Download
A + testing/buildbot/PRESUBMIT.py View 1 2 chunks +5 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.chrome.json View 1 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 1 chunk +485 lines, -177 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 chunks +2416 lines, -939 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 chunks +653 lines, -277 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 4 chunks +488 lines, -242 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 1 chunk +371 lines, -179 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 1 chunk +445 lines, -170 lines 0 comments Download
M testing/buildbot/chromium.perf.json View 1 4 chunks +245 lines, -55 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 14 chunks +837 lines, -249 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 3 chunks +1127 lines, -481 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 1 chunk +34 lines, -30 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 3 chunks +176 lines, -115 lines 0 comments Download
A testing/buildbot/client.v8.json View 1 1 chunk +64 lines, -0 lines 0 comments Download
A testing/buildbot/manage.py View 1 1 chunk +193 lines, -0 lines 0 comments Download
M testing/buildbot/trybot_analyze_config.json View 1 3 chunks +6 lines, -5 lines 0 comments Download
A testing/buildbot/tryserver.blink.json View 1 1 chunk +65 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.chromium.linux.json View 1 1 chunk +198 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.chromium.mac.json View 1 1 chunk +70 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.chromium.perf.json View 1 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/tryserver.chromium.win.json View 1 1 chunk +248 lines, -0 lines 0 comments Download
A testing/buildbot/tryserver.v8.json View 1 1 chunk +64 lines, -0 lines 0 comments Download
M testing/chromoting/browser_test_commands_linux.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M testing/chromoting/browser_tests_launcher.py View 1 6 chunks +78 lines, -38 lines 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 1 1 chunk +4 lines, -0 lines 0 comments Download
A testing/chromoting/dependencies.gypi View 1 1 chunk +25 lines, -0 lines 0 comments Download
M testing/chromoting/integration_tests.gyp View 1 1 chunk +2 lines, -32 lines 0 comments Download
M testing/commit_queue/config.json View 1 6 chunks +15 lines, -16 lines 0 comments Download
M testing/iossim/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M testing/iossim/iossim.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M testing/legion/common_lib.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M testing/legion/examples/hello_world/controller_test.py View 1 1 chunk +50 lines, -55 lines 0 comments Download
M testing/legion/examples/subprocess/subprocess_test.py View 1 1 chunk +55 lines, -49 lines 0 comments Download
M testing/legion/legion.isolate View 1 1 chunk +2 lines, -0 lines 0 comments Download
A testing/legion/legion_test_case.py View 1 1 chunk +135 lines, -0 lines 0 comments Download
A + testing/legion/process.py View 1 4 chunks +69 lines, -36 lines 0 comments Download
M testing/legion/rpc_methods.py View 1 3 chunks +3 lines, -166 lines 0 comments Download
M testing/legion/task_controller.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M testing/legion/task_registration_server.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M testing/scripts/gtest_perf_test.py View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/test.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/xvfb.py View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/junit/BUILD.gn View 1 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/junit/LICENSE View 1 1 chunk +218 lines, -0 lines 0 comments Download
A + third_party/junit/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/junit/README.chromium View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/junit/junit.gyp View 1 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/libevent/event-config.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libevent/libevent_nacl_nonsfi.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download
A + third_party/libxml/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libxml/patches/snprintf_config View 1 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/libxml/patches/snprintf_win32config View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/libxml/src/include/win32config.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libxml/win32/config.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/mockito/BUILD.gn View 1 1 chunk +28 lines, -0 lines 0 comments Download
A + third_party/mockito/LICENSE View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + third_party/mockito/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/mockito/README.chromium View 1 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/mockito/mockito.gyp View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + third_party/modp_b64/DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/modp_b64/modp_b64_nacl.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download
A third_party/robolectric/BUILD.gn View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + third_party/robolectric/LICENSE View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/robolectric/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/robolectric/README.chromium View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/robolectric/licenses/extreme.indiana.edu.license.txt View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + third_party/robolectric/licenses/javolution.license.txt View 1 1 chunk +14 lines, -18 lines 0 comments Download
A + third_party/robolectric/licenses/pivotal.labs.license.txt View 1 1 chunk +2 lines, -4 lines 0 comments Download
A third_party/robolectric/robolectric.gyp View 1 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/tcmalloc/DEPS View 1 1 chunk +7 lines, -0 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb.sh View 1 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/README View 1 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/changelog View 1 1 chunk +0 lines, -196 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/compat View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/control View 1 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/copyright View 1 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/docs View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/libgperftools-dev.dirs View 1 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/libgperftools-dev.install View 1 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/libgperftools0.dirs View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/libgperftools0.install View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/libgperftools0.manpages View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/tcmalloc/vendor/packages/deb/rules View 1 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/rpm.sh View 1 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/tcmalloc/vendor/packages/rpm/rpm.spec View 1 1 chunk +0 lines, -77 lines 0 comments Download
M tools/android/checkstyle/checkstyle.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tools/android/findbugs_plugin/findbugs.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/findbugs_plugin/findbugs_plugin.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/findbugs_plugin/lib/chromiumPlugin.jar View 1 Binary file 0 comments Download
M tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py View 1 2 chunks +68 lines, -17 lines 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M tools/clang/blink_gc_plugin/JsonWriter.h View 1 1 chunk +24 lines, -15 lines 0 comments Download
M tools/clang/plugins/CMakeLists.txt View 1 1 chunk +30 lines, -12 lines 0 comments Download
M tools/clang/plugins/ChromeClassTester.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/clang/plugins/ChromeClassTester.cpp View 1 3 chunks +58 lines, -52 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 1 3 chunks +69 lines, -26 lines 0 comments Download
M tools/clang/plugins/tests/overridden_methods.txt View 1 1 chunk +48 lines, -48 lines 0 comments Download
A tools/clang/plugins/tests/system/windows.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M tools/clang/plugins/tests/test.sh View 1 3 chunks +4 lines, -1 line 0 comments Download
M tools/clang/plugins/tests/virtual_specifiers.cpp View 1 2 chunks +9 lines, -1 line 0 comments Download
M tools/clang/plugins/tests/virtual_specifiers.txt View 1 1 chunk +29 lines, -29 lines 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/clang/scripts/update.py View 1 6 chunks +49 lines, -8 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 6 chunks +33 lines, -11 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 3 chunks +10 lines, -3 lines 0 comments Download
A tools/valgrind/.gitignore View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 2 chunks +20 lines, -5 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 1 chunk +32 lines, -6 lines 0 comments Download
M tools/valgrind/gtest_exclude/base_unittests.gtest-drmemory_win32.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/base_unittests.gtest_mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A tools/valgrind/gtest_exclude/blink_platform_unittests.gtest_win32.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt View 1 2 chunks +4 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt View 1 2 chunks +4 lines, -0 lines 0 comments Download
A tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 5 chunks +15 lines, -20 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/ColorPickerAdvancedComponent.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/DropdownAdapter.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/events/gesture_detection/scale_gesture_detector.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gfx/display_change_notifier_unittest.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M ui/gl/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
5 years, 7 months ago (2015-05-05 23:05:39 UTC) #1
Nick Bray (chromium)
LGTM w/ somewhat pedantic GN fix. https://codereview.chromium.org/1124763003/diff/10001/mojo/public/tools/BUILD.gn File mojo/public/tools/BUILD.gn (right): https://codereview.chromium.org/1124763003/diff/10001/mojo/public/tools/BUILD.gn#newcode41 mojo/public/tools/BUILD.gn:41: assert(target_cpu == "arm", ...
5 years, 7 months ago (2015-05-05 23:27:23 UTC) #2
jamesr
Committed patchset #2 (id:10001) manually as 0fae00061321666ab3a971dea67c1d1219918589.
5 years, 7 months ago (2015-05-05 23:31:59 UTC) #3
jamesr
5 years, 7 months ago (2015-05-05 23:32:49 UTC) #4
Message was sent while issue was closed. 
Thanks Nick!  fixed the {current,target}_cpu bit and landed.  I'll try another
roll now...

Powered by Google App Engine
This is Rietveld 408576698