Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/virtual_specifiers.txt

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« sky/engine/bindings/BUILD.gn ('K') | « tools/clang/plugins/tests/virtual_specifiers.cpp ('k') | tools/clang/scripts/blink_gc_plugin_flags.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 virtual_specifiers.cpp:36:21: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 1 virtual_specifiers.cpp:38:22: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
2 ~MissingOverride() {} 2 ~MissingOverride() {}
3 ^ 3 ^
4 override 4 override
5 virtual_specifiers.cpp:37:11: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 5 virtual_specifiers.cpp:39:12: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
6 void F() {} 6 void F() {}
7 ^ 7 ^
8 override 8 override
9 virtual_specifiers.cpp:43:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'. 9 virtual_specifiers.cpp:45:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
10 virtual ~VirtualAndOverride() OVERRIDE {} 10 virtual ~VirtualAndOverride() OVERRIDE {}
11 ^~~~~~~~ 11 ^~~~~~~~
12 virtual_specifiers.cpp:44:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'. 12 virtual_specifiers.cpp:46:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
13 virtual void F() OVERRIDE {} 13 virtual void F() OVERRIDE {}
14 ^~~~~~~~ 14 ^~~~~~~~
15 virtual_specifiers.cpp:49:3: warning: [chromium-style] 'virtual' is redundant; ' final' implies 'virtual'. 15 virtual_specifiers.cpp:51:3: warning: [chromium-style] 'virtual' is redundant; ' final' implies 'virtual'.
16 virtual ~VirtualAndFinal() FINAL {} 16 virtual ~VirtualAndFinal() FINAL {}
17 ^~~~~~~~ 17 ^~~~~~~~
18 virtual_specifiers.cpp:50:3: warning: [chromium-style] 'virtual' is redundant; ' final' implies 'virtual'. 18 virtual_specifiers.cpp:52:3: warning: [chromium-style] 'virtual' is redundant; ' final' implies 'virtual'.
19 virtual void F() FINAL {} 19 virtual void F() FINAL {}
20 ^~~~~~~~ 20 ^~~~~~~~
21 virtual_specifiers.cpp:55:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'. 21 virtual_specifiers.cpp:57:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
22 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {} 22 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {}
23 ^~~~~~~~ 23 ^~~~~~~~
24 virtual_specifiers.cpp:55:38: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'. 24 virtual_specifiers.cpp:57:38: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
25 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {} 25 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {}
26 ^~~~~~~~~ 26 ^~~~~~~~~
27 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE' 27 virtual_specifiers.cpp:12:18: note: expanded from macro 'OVERRIDE'
28 #define OVERRIDE override 28 #define OVERRIDE override
29 ^ 29 ^
30 virtual_specifiers.cpp:56:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'. 30 virtual_specifiers.cpp:58:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
31 virtual void F() OVERRIDE FINAL {} 31 virtual void F() OVERRIDE FINAL {}
32 ^~~~~~~~ 32 ^~~~~~~~
33 virtual_specifiers.cpp:56:20: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'. 33 virtual_specifiers.cpp:58:20: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
34 virtual void F() OVERRIDE FINAL {} 34 virtual void F() OVERRIDE FINAL {}
35 ^~~~~~~~~ 35 ^~~~~~~~~
36 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE' 36 virtual_specifiers.cpp:12:18: note: expanded from macro 'OVERRIDE'
37 #define OVERRIDE override 37 #define OVERRIDE override
38 ^ 38 ^
39 virtual_specifiers.cpp:61:23: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'. 39 virtual_specifiers.cpp:63:23: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
40 ~OverrideAndFinal() OVERRIDE FINAL {} 40 ~OverrideAndFinal() OVERRIDE FINAL {}
41 ^~~~~~~~~ 41 ^~~~~~~~~
42 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE' 42 virtual_specifiers.cpp:12:18: note: expanded from macro 'OVERRIDE'
43 #define OVERRIDE override 43 #define OVERRIDE override
44 ^ 44 ^
45 virtual_specifiers.cpp:62:12: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'. 45 virtual_specifiers.cpp:64:12: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
46 void F() OVERRIDE FINAL {} 46 void F() OVERRIDE FINAL {}
47 ^~~~~~~~~ 47 ^~~~~~~~~
48 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE' 48 virtual_specifiers.cpp:12:18: note: expanded from macro 'OVERRIDE'
49 #define OVERRIDE override 49 #define OVERRIDE override
50 ^ 50 ^
51 virtual_specifiers.cpp:67:19: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 51 virtual_specifiers.cpp:69:20: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
52 virtual void F() = 0; 52 virtual void F() = 0;
53 ^ 53 ^
54 override 54 override
55 virtual_specifiers.cpp:71:11: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 55 virtual_specifiers.cpp:73:12: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
56 void F() = 0; 56 void F() = 0;
57 ^ 57 ^
58 override 58 override
59 virtual_specifiers.cpp:79:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'. 59 virtual_specifiers.cpp:81:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
60 virtual void F() override = 0; 60 virtual void F() override = 0;
61 ^~~~~~~~ 61 ^~~~~~~~
62 virtual_specifiers.cpp:102:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'. 62 virtual_specifiers.cpp:110:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
63 virtual ~MyTest(); 63 virtual ~MyTest();
64 ^ 64 ^
65 override 65 override
66 virtual_specifiers.cpp:103:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'. 66 virtual_specifiers.cpp:111:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
67 virtual void SetUp() override; 67 virtual void SetUp() override;
68 ^~~~~~~~ 68 ^~~~~~~~
69 17 warnings generated. 69 17 warnings generated.
OLDNEW
« sky/engine/bindings/BUILD.gn ('K') | « tools/clang/plugins/tests/virtual_specifiers.cpp ('k') | tools/clang/scripts/blink_gc_plugin_flags.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698