Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« sky/engine/bindings/BUILD.gn ('K') | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/system/windows.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from overridden_methods.cpp:5: 1 In file included from overridden_methods.cpp:5:
2 ./overridden_methods.h:25:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 2 ./overridden_methods.h:25:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod() = 0; 3 virtual void SomeMethod() = 0;
4 ^ 4 ^
5 override 5 override
6 ./overridden_methods.h:46:26: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 6 ./overridden_methods.h:46:27: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual ~DerivedClass() {} 7 virtual ~DerivedClass() {}
8 ^ 8 ^
9 override 9 override
10 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 10 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
11 virtual void SomeMethod(); 11 virtual void SomeMethod();
12 ^ 12 ^
13 override 13 override
14 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 14 ./overridden_methods.h:52:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
15 virtual void SomeInlineMethod() {} 15 virtual void SomeInlineMethod() {}
16 ^ 16 ^
17 override 17 override
18 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 18 ./overridden_methods.h:56:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
19 virtual void SomeConstMethod() const {} 19 virtual void SomeConstMethod() const {}
20 ^ 20 ^
21 override 21 override
22 ./overridden_methods.h:58:55: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 22 ./overridden_methods.h:58:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
23 virtual void SomeMethodWithExceptionSpec() throw() {} 23 virtual void SomeMethodWithExceptionSpec() throw() {}
24 ^ 24 ^
25 override 25 override
26 ./overridden_methods.h:61:69: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 26 ./overridden_methods.h:61:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
27 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 27 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
28 ^ 28 ^
29 override 29 override
30 ./overridden_methods.h:63:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 30 ./overridden_methods.h:63:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
31 virtual void SomeNonPureBaseMethod() {} 31 virtual void SomeNonPureBaseMethod() {}
32 ^ 32 ^
33 override 33 override
34 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 34 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
35 virtual void SomeMethodWithComment(); // This is a comment. 35 virtual void SomeMethodWithComment(); // This is a comment.
36 ^ 36 ^
37 override 37 override
38 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 38 ./overridden_methods.h:67:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
39 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 39 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
40 ^ 40 ^
41 override 41 override
42 overridden_methods.cpp:15:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 42 overridden_methods.cpp:15:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
43 virtual void SomeMethod() = 0; 43 virtual void SomeMethod() = 0;
44 ^ 44 ^
45 override 45 override
46 overridden_methods.cpp:22:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 46 overridden_methods.cpp:22:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
47 virtual ~ImplementationDerivedClass() {} 47 virtual ~ImplementationDerivedClass() {}
48 ^ 48 ^
49 override 49 override
50 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 50 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
51 virtual void SomeMethod(); 51 virtual void SomeMethod();
52 ^ 52 ^
53 override 53 override
54 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 54 overridden_methods.cpp:28:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
55 virtual void SomeInlineMethod() {} 55 virtual void SomeInlineMethod() {}
56 ^ 56 ^
57 override 57 override
58 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 58 overridden_methods.cpp:32:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
59 virtual void SomeConstMethod() const {} 59 virtual void SomeConstMethod() const {}
60 ^ 60 ^
61 override 61 override
62 overridden_methods.cpp:34:55: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 62 overridden_methods.cpp:34:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
63 virtual void SomeMethodWithExceptionSpec() throw() {} 63 virtual void SomeMethodWithExceptionSpec() throw() {}
64 ^ 64 ^
65 override 65 override
66 overridden_methods.cpp:37:69: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 66 overridden_methods.cpp:37:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
67 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 67 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
68 ^ 68 ^
69 override 69 override
70 overridden_methods.cpp:39:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 70 overridden_methods.cpp:39:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
71 virtual void SomeNonPureBaseMethod() {} 71 virtual void SomeNonPureBaseMethod() {}
72 ^ 72 ^
73 override 73 override
74 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 74 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
75 virtual void SomeMethodWithComment(); // This is a comment. 75 virtual void SomeMethodWithComment(); // This is a comment.
76 ^ 76 ^
77 override 77 override
78 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 78 overridden_methods.cpp:43:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
79 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 79 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
80 ^ 80 ^
81 override 81 override
82 20 warnings generated. 82 20 warnings generated.
OLDNEW
« sky/engine/bindings/BUILD.gn ('K') | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/system/windows.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698