base/memory/shared_memory_unittest.cc - Issue 1124763003: Update from https://crrev.com/327068

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_unittest.cc

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/shared_memory_unittest.cc

diff --git a/base/memory/shared_memory_unittest.cc b/base/memory/shared_memory_unittest.cc

index 6e5a4d8f7ee6cdee7c025fc0d048a44a3ba8247d..6fe57060e6fcd6cd83853875fcea4c1595c52138 100644

--- a/base/memory/shared_memory_unittest.cc

+++ b/base/memory/shared_memory_unittest.cc

@@ -101,10 +101,10 @@ const char* const MultipleThreadMain::s_test_name_ =

class MultipleLockThread : public PlatformThread::Delegate {

public:

explicit MultipleLockThread(int id) : id_(id) {}

- virtual ~MultipleLockThread() {}

+ ~MultipleLockThread() override {}

// PlatformThread::Delegate interface.

- virtual void ThreadMain() override {

+ void ThreadMain() override {

const uint32 kDataSize = sizeof(int);

SharedMemoryHandle handle = NULL;

{