sky/engine/bindings/BUILD.gn - Issue 1124763003: Update from https://crrev.com/327068

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/BUILD.gn

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/BUILD.gn

diff --git a/sky/engine/bindings/BUILD.gn b/sky/engine/bindings/BUILD.gn

index 0e8edf2363ecfa6347a482d54aa6f1a519f830db..b7dbafe6c1551dd92d964b39f50a6a675da9d9d6 100644

--- a/sky/engine/bindings/BUILD.gn

+++ b/sky/engine/bindings/BUILD.gn

@@ -89,7 +89,7 @@ action("generate_snapshot_bin") {

"--output_bin",

rebase_path(isolate_snapshot, root_build_dir),

"--target_os",

- os,

+ target_os,

Nick Bray (chromium) 2015/05/05 23:27:23 Yes, it's kinda freaky you would pass "current_os"

"--url_mapping=dart:sky,$dart_sky_path",

"--url_mapping=dart:mojo.internal,$internal_path",

"--url_mapping=dart:sky_builtin,$builtin_path",