base/strings/string_split.cc - Issue 1124763003: Update from https://crrev.com/327068

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_split.cc

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_split.cc

diff --git a/base/strings/string_split.cc b/base/strings/string_split.cc

index 692f3008e7827cf9b57a25a58d8e74509f92b373..88a623664fcc1c256de60c110c3186ecc0034885 100644

--- a/base/strings/string_split.cc

+++ b/base/strings/string_split.cc

@@ -6,7 +6,6 @@

#include "base/logging.h"

#include "base/strings/string_util.h"

-#include "base/strings/utf_string_conversions.h"

#include "base/third_party/icu/icu_utf.h"

namespace base {

@@ -193,7 +192,6 @@ void SplitStringDontTrim(const string16& str,

void SplitStringDontTrim(const std::string& str,

char c,

std::vector<std::string>* r) {

- DCHECK(IsStringUTF8(str));

#if CHAR_MIN < 0

DCHECK_GE(c, 0);

#endif