Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2008)

Unified Diff: base/files/file.h

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file.h
diff --git a/base/files/file.h b/base/files/file.h
index 13c8a96fcefe29ad89112946e705ae86e07790bd..89077b41c1d8d03a9aa1e33ea822b9fb9454f807 100644
--- a/base/files/file.h
+++ b/base/files/file.h
@@ -150,13 +150,13 @@ class BASE_EXPORT File {
bool is_symbolic_link;
// The last modified time of a file.
- base::Time last_modified;
+ Time last_modified;
// The last accessed time of a file.
- base::Time last_accessed;
+ Time last_accessed;
// The creation time of a file.
- base::Time creation_time;
+ Time creation_time;
};
File();
@@ -182,10 +182,6 @@ class BASE_EXPORT File {
// Creates or opens the given file.
void Initialize(const FilePath& name, uint32 flags);
- // Creates or opens the given file, allowing paths with traversal ('..')
- // components. Use only with extreme care.
- void InitializeUnsafe(const FilePath& name, uint32 flags);
-
bool IsValid() const;
// Returns true if a new file was created (or an old one truncated to zero
@@ -354,6 +350,14 @@ class BASE_EXPORT File {
};
#endif
+ // Creates or opens the given file. Only called if |name| has no traversal
+ // ('..') components.
+ void DoInitialize(const FilePath& name, uint32 flags);
+
+ // TODO(tnagel): Reintegrate into Flush() once histogram isn't needed anymore,
+ // cf. issue 473337.
+ bool DoFlush();
+
void SetPlatformFile(PlatformFile file);
#if defined(OS_WIN)
« no previous file with comments | « base/file_version_info_win.h ('k') | base/files/file.cc » ('j') | mojo/public/tools/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698