Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed)

Created:
7 years ago by vadimt
Modified:
7 years ago
Reviewers:
Adam Rice, vadimt
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 239921 "Revert 239759 "The comment in base64.h implies th..." ***************** Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess. ***************** > Revert 239759 "The comment in base64.h implies that base::Base64..." > > > The comment in base64.h implies that base::Base64Encode() can return false, but > > this cannot happen in practice. Fix the comment. > > > > The implementation of Base64Encode() attempts to check for the return value > > MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this > > value. Remove the check. > > > > Remove unneeded integer cast. > > > > Change the return type to void. > > > > BUG=323357 > > TEST=base_unittests, compile all > > TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org > > > > Review URL: https://codereview.chromium.org/86913002 > > TBR=ricea@chromium.org > > Review URL: https://codereview.chromium.org/101113004 TBR=vadimt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -250 lines) Patch
M trunk/src/base/base64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/base/base64.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M trunk/src/base/base64_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/settings/device_settings_cache.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/devtools/adb/android_rsa.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_protocols.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/extensions/install_signer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/internal_auth.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/managed_mode/managed_user_registration_utility.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/media/desktop_streams_registry.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_log.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_log_serializer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/metrics/variations/variations_http_header_provider.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/metrics/variations/variations_service.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/metrics/variations/variations_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service_harness.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/certificate_dialogs.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/chrome_launcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/net/websocket.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/components/policy/core/common/cloud/resource_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/content/browser/devtools/renderer_overrides_handler.cc View 2 chunks +8 lines, -18 lines 0 comments Download
M trunk/src/content/common/page_state_serialization_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/webkit_test_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/shell/renderer/webkit_test_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/extensions/common/extension.cc View 1 chunk +4 lines, -1 line 0 comments Download
M trunk/src/google_apis/cup/client_update_protocol.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/google_apis/gaia/oauth_request_signer.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M trunk/src/jingle/notifier/listener/push_notifications_send_update_task.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M trunk/src/jingle/notifier/listener/push_notifications_send_update_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/keygen_handler_win.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/net/cert/x509_certificate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/http/http_auth_gssapi_posix.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/net/http/http_auth_handler_basic.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M trunk/src/net/http/http_auth_handler_ntlm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/net/http/http_auth_sspi_win.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/net/test/spawned_test_server/base_test_server.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/net/third_party/mozilla_security_manager/nsKeygenHandler.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M trunk/src/net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/websockets/websocket_handshake_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/remoting/base/rsa_key_pair.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/remoting/host/pin_hash.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/remoting/host/token_validator_factory_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/remoting/protocol/auth_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/remoting/protocol/authenticator_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/remoting/protocol/pairing_registry.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/remoting/protocol/v2_authenticator.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M trunk/src/sync/internal_api/public/base/unique_position_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/internal_api/sync_encryption_handler_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/sync/syncable/syncable_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/tools/null_invalidation_state_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/util/cryptographer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/sync/util/nigori.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vadimt
7 years ago (2013-12-11 01:48:31 UTC) #1
vadimt
Committed patchset #1 manually as r239944.
7 years ago (2013-12-11 01:48:55 UTC) #2
vadimt
7 years ago (2013-12-11 01:56:38 UTC) #3
Message was sent while issue was closed.
+ original author

Powered by Google App Engine
This is Rietveld 408576698