Revert 239921 "Revert 239759 "The comment in base64.h implies th..."

trunk/src/chrome/common/metrics/caching_permuted_entropy_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/metrics/caching_permuted_entropy_provider.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/logging.h"
@@ skipping 48 matching lines @@
     local_state_->ClearPref(prefs::kMetricsPermutedEntropyCache);
     NOTREACHED();
   }
 }
 
 void CachingPermutedEntropyProvider::UpdateLocalState() const {
   std::string serialized;
   cache_.SerializeToString(&serialized);
 
   std::string base64_encoded;
-  if (!base::Base64Encode(serialized, &base64_encoded)) {
-    NOTREACHED();
-    return;
-  }
+  base::Base64Encode(serialized, &base64_encoded);
   local_state_->SetString(prefs::kMetricsPermutedEntropyCache, base64_encoded);
 }
 
 void CachingPermutedEntropyProvider::AddToCache(uint32 randomization_seed,
                                                 uint16 value) const {
   PermutedEntropyCache::Entry* entry;
   const int kMaxSize = 25;
   if (cache_.entry_size() >= kMaxSize) {
     // If the cache is full, evict the first entry, swapping later entries in
     // to take its place. This effectively creates a FIFO cache, which is good
@@ skipping 18 matching lines @@
   for (int i = 0; i < cache_.entry_size(); ++i) {
     if (cache_.entry(i).randomization_seed() == randomization_seed) {
       *value = cache_.entry(i).value();
       return true;
     }
   }
   return false;
 }
 
 }  // namespace metrics