Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: trunk/src/google_apis/cup/client_update_protocol.cc

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/extensions/common/extension.cc ('k') | trunk/src/google_apis/gaia/oauth_request_signer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/google_apis/cup/client_update_protocol.cc
===================================================================
--- trunk/src/google_apis/cup/client_update_protocol.cc (revision 239942)
+++ trunk/src/google_apis/cup/client_update_protocol.cc (working copy)
@@ -122,8 +122,7 @@
// needed. Call the standard Base64 encoder/decoder and then apply fixups.
std::string UrlSafeB64Encode(const std::vector<uint8>& data) {
std::string result;
- if (!base::Base64Encode(ByteVectorToSP(data), &result))
- return std::string();
+ base::Base64Encode(ByteVectorToSP(data), &result);
// Do an tr|+/|-_| on the output, and strip any '=' padding.
for (std::string::iterator it = result.begin(); it != result.end(); ++it) {
@@ -302,4 +301,3 @@
return true;
}
-
« no previous file with comments | « trunk/src/extensions/common/extension.cc ('k') | trunk/src/google_apis/gaia/oauth_request_signer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698