Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: trunk/src/net/test/spawned_test_server/base_test_server.cc

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/net/test/spawned_test_server/base_test_server.cc
===================================================================
--- trunk/src/net/test/spawned_test_server/base_test_server.cc (revision 239942)
+++ trunk/src/net/test/spawned_test_server/base_test_server.cc (working copy)
@@ -226,10 +226,8 @@
const std::string& new_text = it->second;
std::string base64_old;
std::string base64_new;
- if (!base::Base64Encode(old_text, &base64_old))
- return false;
- if (!base::Base64Encode(new_text, &base64_new))
- return false;
+ base::Base64Encode(old_text, &base64_old);
+ base::Base64Encode(new_text, &base64_new);
if (first_query_parameter) {
new_file_path += "?";
first_query_parameter = false;
@@ -400,8 +398,7 @@
}
if (!ssl_options_.signed_cert_timestamps.empty()) {
std::string b64_scts;
- if (!base::Base64Encode(ssl_options_.signed_cert_timestamps, &b64_scts))
- return false;
+ base::Base64Encode(ssl_options_.signed_cert_timestamps, &b64_scts);
arguments->SetString("signed-cert-timestamps", b64_scts);
}
}
« no previous file with comments | « trunk/src/net/http/http_auth_sspi_win.cc ('k') | trunk/src/net/third_party/mozilla_security_manager/nsKeygenHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698