Revert 239921 "Revert 239759 "The comment in base64.h implies th..."

trunk/src/chrome/test/chromedriver/chrome_launcher.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/chrome_launcher.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 479 matching lines @@
   // Get extension's ID from public key in crx file.
   // Assumes crx v2. See http://developer.chrome.com/extensions/crx.html.
   std::string key_len_str = decoded_extension.substr(8, 4);
   if (key_len_str.size() != 4)
     return Status(kUnknownError, "cannot extract public key length");
   uint32 key_len = *reinterpret_cast<const uint32*>(key_len_str.c_str());
   std::string public_key = decoded_extension.substr(16, key_len);
   if (key_len != public_key.size())
     return Status(kUnknownError, "invalid public key length");
   std::string public_key_base64;
-  if (!base::Base64Encode(public_key, &public_key_base64))
-    return Status(kUnknownError, "cannot base64 encode public key");
+  base::Base64Encode(public_key, &public_key_base64);
   std::string id = GenerateExtensionId(public_key);
 
   // Unzip the crx file.
   base::ScopedTempDir temp_crx_dir;
   if (!temp_crx_dir.CreateUniqueTempDir())
     return Status(kUnknownError, "cannot create temp dir");
   base::FilePath extension_crx = temp_crx_dir.path().AppendASCII("temp.crx");
   int size = static_cast<int>(decoded_extension.length());
   if (file_util::WriteFile(extension_crx, decoded_extension.c_str(), size) !=
       size) {
@@ skipping 165 matching lines @@
   // Write empty "First Run" file, otherwise Chrome will wipe the default
   // profile that was written.
   if (file_util::WriteFile(
           user_data_dir.AppendASCII("First Run"), "", 0) != 0) {
     return Status(kUnknownError, "failed to write first run file");
   }
   return Status(kOk);
 }
 
 }  // namespace internal