Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: trunk/src/chrome/browser/media/desktop_streams_registry.cc

Issue 111883004: Revert 239921 "Revert 239759 "The comment in base64.h implies th..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/media/desktop_streams_registry.cc
===================================================================
--- trunk/src/chrome/browser/media/desktop_streams_registry.cc (revision 239942)
+++ trunk/src/chrome/browser/media/desktop_streams_registry.cc (working copy)
@@ -20,10 +20,8 @@
char buffer[kStreamIdLengthBytes];
crypto::RandBytes(buffer, arraysize(buffer));
std::string result;
- if (!base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),
- &result)) {
- LOG(FATAL) << "Base64Encode failed.";
- }
+ base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),
+ &result);
return result;
}

Powered by Google App Engine
This is Rietveld 408576698