Revert 239921 "Revert 239759 "The comment in base64.h implies th..."

trunk/src/content/browser/devtools/renderer_overrides_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/renderer_overrides_handler.h"
 
 #include <map>
 #include <string>
 
 #include "base/barrier_closure.h"
@@ skipping 425 matching lines @@
       gfx::ScaleSize(view_bounds.size(), scale));
 
   // Grab screen pixels if available for current platform.
   // TODO(pfeldman): support format, scale and quality in ui::GrabViewSnapshot.
   std::vector<unsigned char> png;
   bool is_unscaled_png = scale == 1 && format == kPng;
   if (is_unscaled_png && ui::GrabViewSnapshot(host->GetView()->GetNativeView(),
                                               &png,
                                               gfx::Rect(snapshot_size))) {
     std::string base64_data;
-    bool success = base::Base64Encode(
+    base::Base64Encode(
         base::StringPiece(reinterpret_cast<char*>(&*png.begin()), png.size()),
         &base64_data);
-    if (success) {
-      base::DictionaryValue* result = new base::DictionaryValue();
-      result->SetString(
-          devtools::Page::captureScreenshot::kResponseData, base64_data);
-      return command->SuccessResponse(result);
-    }
-    return command->InternalErrorResponse("Unable to base64encode screenshot");
+    base::DictionaryValue* result = new base::DictionaryValue();
+    result->SetString(
+        devtools::Page::captureScreenshot::kResponseData, base64_data);
+    return command->SuccessResponse(result);
   }
 
   // Fallback to copying from compositing surface.
   RenderWidgetHostViewPort* view_port =
       RenderWidgetHostViewPort::FromRWHV(host->GetView());
 
   view_port->CopyFromCompositingSurface(
       view_bounds, snapshot_size,
       base::Bind(&RendererOverridesHandler::ScreenshotCaptured,
                  weak_factory_.GetWeakPtr(), command, format, quality,
@@ skipping 80 matching lines @@
 
   if (!encoded) {
     if (command) {
       SendAsyncResponse(
           command->InternalErrorResponse("Unable to encode screenshot"));
     }
     return;
   }
 
   std::string base_64_data;
-  if (!base::Base64Encode(base::StringPiece(
-                              reinterpret_cast<char*>(&data[0]),
-                              data.size()),
-                          &base_64_data)) {
-    if (command) {
-      SendAsyncResponse(
-          command->InternalErrorResponse("Unable to base64 encode"));
-    }
-    return;
-  }
+  base::Base64Encode(
+      base::StringPiece(reinterpret_cast<char*>(&data[0]), data.size()),
+      &base_64_data);
 
   base::DictionaryValue* response = new base::DictionaryValue();
   response->SetString(devtools::Page::screencastFrame::kParamData,
                       base_64_data);
 
   // Consider metadata empty in case it has no device scale factor.
   if (metadata.device_scale_factor != 0) {
     base::DictionaryValue* response_metadata = new base::DictionaryValue();
 
     response_metadata->SetDouble(
@@ skipping 404 matching lines @@
       return NULL;
     }
     event.data.pinchUpdate.scale = static_cast<float>(scale);
   }
 
   host->ForwardGestureEvent(event);
   return command->SuccessResponse(NULL);
 }
 
 }  // namespace content