Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace Handle<> with Local in remaining gin/* Handle is an alias for Local BUG=424445 Committed: https://crrev.com/faaa1b6a4752b7c454ccc465ad40e4999229bd77 Cr-Commit-Position: refs/heads/master@{#327672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -186 lines) Patch
M gin/arguments.h View 3 chunks +3 lines, -3 lines 0 comments Download
M gin/arguments.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gin/array_buffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M gin/array_buffer.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M gin/context_holder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/converter.h View 3 chunks +49 lines, -49 lines 0 comments Download
M gin/converter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gin/converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/dictionary.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gin/dictionary.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gin/function_template.h View 4 chunks +4 lines, -4 lines 0 comments Download
M gin/function_template.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/handle.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gin/interceptor_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M gin/object_template_builder.h View 5 chunks +9 lines, -9 lines 0 comments Download
M gin/object_template_builder.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M gin/per_context_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gin/per_context_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gin/per_context_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gin/public/context_holder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gin/public/wrapper_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gin/runner.h View 1 chunk +4 lines, -4 lines 0 comments Download
M gin/shell_runner.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gin/shell_runner.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M gin/test/file.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gin/test/file_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/test/gtest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gin/try_catch.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gin/wrappable.h View 4 chunks +5 lines, -5 lines 0 comments Download
M gin/wrappable.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M gin/wrappable_unittest.cc View 6 chunks +22 lines, -22 lines 0 comments Download
M gin/wrapper_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-30 04:15:31 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-30 04:17:26 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-30 07:25:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112923003/1
5 years, 7 months ago (2015-04-30 07:26:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 07:30:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:31:45 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/faaa1b6a4752b7c454ccc465ad40e4999229bd77
Cr-Commit-Position: refs/heads/master@{#327672}

Powered by Google App Engine
This is Rietveld 408576698