Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: gin/shell_runner.cc

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/shell_runner.h ('k') | gin/test/file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/shell_runner.cc
diff --git a/gin/shell_runner.cc b/gin/shell_runner.cc
index 8d98e425d745da3ec3236d0f08745fb16e84a4d1..eccee9f69ca355f47255e1f25d2c3973f496a0af 100644
--- a/gin/shell_runner.cc
+++ b/gin/shell_runner.cc
@@ -25,10 +25,10 @@ ShellRunnerDelegate::ShellRunnerDelegate() {
ShellRunnerDelegate::~ShellRunnerDelegate() {
}
-v8::Handle<ObjectTemplate> ShellRunnerDelegate::GetGlobalTemplate(
+v8::Local<ObjectTemplate> ShellRunnerDelegate::GetGlobalTemplate(
ShellRunner* runner,
v8::Isolate* isolate) {
- return v8::Handle<ObjectTemplate>();
+ return v8::Local<ObjectTemplate>();
}
void ShellRunnerDelegate::DidCreateContext(ShellRunner* runner) {
@@ -49,7 +49,7 @@ ShellRunner::ShellRunner(ShellRunnerDelegate* delegate, Isolate* isolate)
: delegate_(delegate) {
v8::Isolate::Scope isolate_scope(isolate);
HandleScope handle_scope(isolate);
- v8::Handle<v8::Context> context =
+ v8::Local<v8::Context> context =
Context::New(isolate, NULL, delegate_->GetGlobalTemplate(this, isolate));
context_holder_.reset(new ContextHolder(isolate));
@@ -67,7 +67,7 @@ void ShellRunner::Run(const std::string& source,
const std::string& resource_name) {
TryCatch try_catch;
v8::Isolate* isolate = GetContextHolder()->isolate();
- v8::Handle<Script> script = Script::Compile(
+ v8::Local<Script> script = Script::Compile(
StringToV8(isolate, source), StringToV8(isolate, resource_name));
if (try_catch.HasCaught()) {
delegate_->UnhandledException(this, try_catch);
@@ -77,14 +77,14 @@ void ShellRunner::Run(const std::string& source,
Run(script);
}
-v8::Handle<v8::Value> ShellRunner::Call(v8::Handle<v8::Function> function,
- v8::Handle<v8::Value> receiver,
+v8::Local<v8::Value> ShellRunner::Call(v8::Local<v8::Function> function,
+ v8::Local<v8::Value> receiver,
int argc,
- v8::Handle<v8::Value> argv[]) {
+ v8::Local<v8::Value> argv[]) {
TryCatch try_catch;
delegate_->WillRunScript(this);
- v8::Handle<v8::Value> result = function->Call(receiver, argc, argv);
+ v8::Local<v8::Value> result = function->Call(receiver, argc, argv);
delegate_->DidRunScript(this);
if (try_catch.HasCaught())
@@ -97,7 +97,7 @@ ContextHolder* ShellRunner::GetContextHolder() {
return context_holder_.get();
}
-void ShellRunner::Run(v8::Handle<Script> script) {
+void ShellRunner::Run(v8::Local<Script> script) {
TryCatch try_catch;
delegate_->WillRunScript(this);
« no previous file with comments | « gin/shell_runner.h ('k') | gin/test/file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698