Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: gin/object_template_builder.h

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/object_template_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/object_template_builder.h
diff --git a/gin/object_template_builder.h b/gin/object_template_builder.h
index 1305d5ce3ac934de11682e136422203d6745b3f3..1e53d83a1511adf6f178d873cc6c886ed901db93 100644
--- a/gin/object_template_builder.h
+++ b/gin/object_template_builder.h
@@ -23,7 +23,7 @@ namespace {
// because of base::Bind().
template<typename T, typename Enable = void>
struct CallbackTraits {
- static v8::Handle<v8::FunctionTemplate> CreateTemplate(v8::Isolate* isolate,
+ static v8::Local<v8::FunctionTemplate> CreateTemplate(v8::Isolate* isolate,
T callback) {
return CreateFunctionTemplate(isolate, base::Bind(callback));
}
@@ -37,7 +37,7 @@ struct CallbackTraits {
// Specialization for base::Callback.
template<typename T>
struct CallbackTraits<base::Callback<T> > {
- static v8::Handle<v8::FunctionTemplate> CreateTemplate(
+ static v8::Local<v8::FunctionTemplate> CreateTemplate(
v8::Isolate* isolate, const base::Callback<T>& callback) {
return CreateFunctionTemplate(isolate, callback);
}
@@ -55,7 +55,7 @@ struct CallbackTraits<base::Callback<T> > {
template<typename T>
struct CallbackTraits<T, typename base::enable_if<
base::is_member_function_pointer<T>::value>::type> {
- static v8::Handle<v8::FunctionTemplate> CreateTemplate(v8::Isolate* isolate,
+ static v8::Local<v8::FunctionTemplate> CreateTemplate(v8::Isolate* isolate,
T callback) {
return CreateFunctionTemplate(isolate, base::Bind(callback),
HolderIsFirstArgument);
@@ -71,9 +71,9 @@ struct CallbackTraits<T, typename base::enable_if<
// This specialization allows people to construct function templates directly if
// they need to do fancier stuff.
template<>
-struct CallbackTraits<v8::Handle<v8::FunctionTemplate> > {
- static v8::Handle<v8::FunctionTemplate> CreateTemplate(
- v8::Handle<v8::FunctionTemplate> templ) {
+struct CallbackTraits<v8::Local<v8::FunctionTemplate> > {
+ static v8::Local<v8::FunctionTemplate> CreateTemplate(
+ v8::Local<v8::FunctionTemplate> templ) {
return templ;
}
};
@@ -131,10 +131,10 @@ class GIN_EXPORT ObjectTemplateBuilder {
private:
ObjectTemplateBuilder& SetImpl(const base::StringPiece& name,
- v8::Handle<v8::Data> val);
+ v8::Local<v8::Data> val);
ObjectTemplateBuilder& SetPropertyImpl(
- const base::StringPiece& name, v8::Handle<v8::FunctionTemplate> getter,
- v8::Handle<v8::FunctionTemplate> setter);
+ const base::StringPiece& name, v8::Local<v8::FunctionTemplate> getter,
+ v8::Local<v8::FunctionTemplate> setter);
v8::Isolate* isolate_;
« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/object_template_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698